Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially implement WifiEnumerateAccessPoints to expose access point ids #113

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 18, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Implement WifiEnumerateAccessPoints API.

Technical Details

Partially implement WifiEnumerateAccessPoints to surface discovered APs, populating their id (interface name) only.

  • Fix -v flag for netremote-server.
  • Add some logging for AP discovery.
  • Probe for access points when a discovery agent is added to ensure pre-existing devices are discovered.
  • Update netremote-cli to display discovered access points.
  • Update IEEE 802.11 cipher and akm suites with values from the spec instead of a combination of Windows and Linux types.
  • Use short macros LOG<E|W|I> instead of those with full names like LOG_<ERROR|WARNING|INFO>.

Test Results

  • All unit tests pass.
  • Ran netremote-cli on a Linux machine with 2 AP-capable wi-fi devices with the following results:
shadowfax@mrstux:~/src/microsoft/netremote-cmake/out/install/dev-linux/bin$ ./netremote-cli -s localhost wifi enumaps
Executing command WifiEnumerateAccessPoints
2 access points discovered
 - [wlx08beac0696fe]
 - [wls1]

Reviewer Focus

  • None

Future Work

  • Populate WifiEnumerateAccessPoints results with access point capabilities. That portion is too large for this already sizable PR.
  • Update AccessPointManager to accept an IAccessPointFactory to create access point instances instead of creating the base class type AccessPoint.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 18, 2024 21:21
@abeltrano abeltrano merged commit 8029c7c into develop Jan 18, 2024
2 of 4 checks passed
@abeltrano abeltrano deleted the apcapsapi branch January 18, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant