Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow supplying address without port. #112

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Allow supplying address without port. #112

merged 1 commit into from
Jan 18, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow specifying the server address with netremote-cli without a port, eg. netremote-cli -s 1.2.3.4 instead of netremote-cli -s 1.2.3.4:5047.

Technical Details

  • Detect when no port is specified, and append the default port (5047).
  • Define port separator in static protocol info.

Test Results

shadowfax@mrstux:~/src/microsoft/netremote-cmake/out/install/dev-linux/bin$ ./netremote-cli -s localhost wifi enumaps
Executing command WifiEnumerateAccessPoints

Reviewer Focus

  • None

Future Work

  • Possibly auto-detect if the service is running locally, and allow no address to be specified in this case.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 18, 2024 18:04
@abeltrano abeltrano merged commit f181625 into develop Jan 18, 2024
3 checks passed
@abeltrano abeltrano deleted the addressNoPort branch January 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant