Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ProbeAsync for AccessPointDiscoveryAgentOperationsNetlink #107

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow the subsystem to detect pre-existing interfaces when the server starts.

Technical Details

  • Implement AccessPointDiscoveryAgentOperationsNetlink::ProbeAsync() using the nl80211 NL80211_CMD_GET_INTERFACE command with the dump flag.
  • Add Netlink80211Interface helper class to represent nl80211 interfaces.
  • Add helper function CreateNl80211Socket to create a socket which is connected with the nl80211 genl protocol.
  • Add helper Netlink::Allocate() function to create a new wrapper with a pre-allocated netlink socket.

Test Results

  • All existing and new unit tests pass.

Reviewer Focus

  • None

Future Work

  • Make use of the ProbeAsync function to populate initial interfaces.
  • Implement better error signaling (some void functions just return on error, some non-void functions return empty collections, etc.).

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 12, 2024 19:46
@abeltrano abeltrano merged commit 9274810 into develop Jan 12, 2024
4 checks passed
@abeltrano abeltrano deleted the approbe branch January 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant