Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration of components on test+development machines #104

Merged
merged 10 commits into from
Jan 12, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ease testing on development machine.
  • Enable sandboxing testing components.

Technical Details

  • Add templated systemd service unit file for hostapd which parameterizes the wlan interface (eg. systemctl enable hostapd@wlan0).
  • Remove non-templated system service unit file for hostapd. This form is unlikely to be used since it hardcodes the wlan interface name and would require interface renaming logic on the server system, introducing complexity and some races.
  • Install the hostapd binary and libwpa_client.so shared object library.
  • Rename example hostapd.conf to hostapd.example.conf to make clear that it's an example file.
  • Add comments to hostapd.example.conf describing the modifications needed to use it with an instantiated systemd service unit.
  • Add network device subsystem requirement and sequencing directives in the hostapd systemd service unit template, to ensure the network subsystem is ready before starting the hostapd daemon.
  • Append wlan interface name to hostapd pid file to help differentiate ownership.
  • Use full paths for install locations in configure-files to allow use of project artifacts.

Test Results

  • Validated filesystem tree for cmake --install is as expected.
  • Validated configured files, [email protected] and hostapd.example.conf reference correct paths.

Reviewer Focus

  • None

Future Work

  • Consider authoring a script which installs the systemd service unit files for production.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 12, 2024 02:59
@abeltrano abeltrano merged commit 3ca7359 into develop Jan 12, 2024
2 of 4 checks passed
@abeltrano abeltrano deleted the apcfg branch January 12, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant