Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHERRY-PICK] Add required functionality to the Tpm12CommandLib. #360

Conversation

kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Nov 28, 2024

Description

Add required functionality to the Tpm12CommandLib for legacy platforms.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on legacy intel platforms

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Nov 28, 2024
@kenlautner kenlautner added type:backport Backport changes in a dev branch PR to its release branch. and removed impact:non-functional Does not have a functional impact labels Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 1.44%. Comparing base (b4a89eb) to head (b731242).

Files with missing lines Patch % Lines
...tyPkg/Library/Tpm12CommandLib/Tpm12GetCapability.c 0.00% 21 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           dev/202405    #360      +/-   ##
=============================================
- Coverage        1.45%   1.44%   -0.01%     
=============================================
  Files             146     146              
  Lines           36869   36917      +48     
  Branches          273     273              
=============================================
  Hits              535     535              
- Misses          36334   36382      +48     
Flag Coverage Δ
SecurityPkg 1.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Dec 2, 2024
@kenlautner
Copy link
Contributor Author

Closing PR as the platforms mentioned in the PR never use TPM12 even though they technically supported it. Instead we're removing the legacy TPM12 code for those devices.

@kenlautner kenlautner closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants