use external dependency for cargo tools on windows #1105
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo tools (tarpaulin / make) are provided for free when using the provided devcontainer. However, on Windows, these tools must be installed or downloaded manually at a specific issue. This has caused frequent issues for developers as local installation via compilation tend to fail as this project uses an outdated version of rust. This change adds these tools as external dependencies, so that developers who only care about compiling the project can do so without having to worry about installing these additional tools.
github-actions
bot
added
the
impact:non-functional
|
I like this. I am worried about another subhook situation, where the ext_dep source disappears. |
This is definitely a fair point. we could publish them somewhere ourselves, Maybe as an ado artifact for project mu: https://dev.azure.com/projectmu/mu/_artifacts/feed/Mu-Public |
kuqin12
approved these changes
Feb 4, 2025
That sounds fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cargo tools (tarpaulin / make) are provided for free when using the provided devcontainer. However, on Windows, these tools must be installed or downloaded manually at a specific version. This has caused frequent issues for developers as local installation via compilation tend to fail as this project uses an outdated version of rust.
This change adds these tools as external dependencies, so that developers who only care about compiling the project can do so without having to worry about installing these additional tools.
How This Was Tested
Removed my installation of cargo-make and cargo-tarpaulin and was still able to run stuart_build and stuart_ci_build
Integration Instructions
N/A