FIX: Python library linking - not using 3.13.4 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR pins the Python version in the build and validation pipelines to 3.13.3 as a temporary workaround for issues with Python 3.13.4.
- Updated
versionSpecin the PR validation pipeline to ‘3.13.3’ with explanatory comments. - Updated
pythonVersionin the wheel build pipeline to ‘3.13.3’ for both x64 and arm64 jobs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/pr-validation-pipeline.yml | Pin Python versionSpec to 3.13.3 and add workaround comments |
| eng/pipelines/build-whl-pipeline.yml | Pin pythonVersion to 3.13.3 for x64 and arm64 jobs |
Comments suppressed due to low confidence (2)
eng/pipelines/pr-validation-pipeline.yml:23
- Update the displayName to reflect the patch version, e.g., 'Use Python 3.13.3', to match the versionSpec.
displayName: 'Use Python 3.13'
eng/pipelines/build-whl-pipeline.yml:60
- For the py313_arm64 job, the architecture field is set to 'x64' but should be 'arm64' to match the targetArch.
architecture: 'x64'
|
Referencing Issue python/cpython#135151 from Python release which is causing the compilation to fail (linking the wrong debug library) - This is a temporary fix which should be reverted back when the new version of Python gets released. Patching this separately since this is an off case. |
bewithgaurav
changed the title
bewithgaurav
changed the title
sumitmsft
approved these changes
Jun 16, 2025
gargsaumya
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the Python version used in the build and validation pipelines to address a known issue with Python 3.13.4 and ensure compatibility with Python 3.13.5. The changes include adjustments to the version specifications and relevant comments for clarity.
Pipeline updates:
eng/pipelines/build-whl-pipeline.yml: Updated thepythonVersionforpy313_x64andpy313_arm64jobs from3.13to3.13.5to ensure the use of the latest compatible version.eng/pipelines/pr-validation-pipeline.yml: Updated theversionSpecin theUsePythonVersiontask to3.13.5and added a comment explaining the temporary workaround due to ADO indexing delays and known issues with Python 3.13.4.Issue Reference
Fixes AB#37710
Checklist
Testing Performed
3.13.3Windows