Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clang compatibility #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Clang compatibility #636

wants to merge 1 commit into from

Conversation

mtxn2147
Copy link

fix compatibility issue with platforms using clang. Due to the difference in standard implementations, a change of the C++ standard from 14 to 17 is required to properly build the project on these platforms.

compilation errors with clang18:

...
/usr/include/unicode/localpointer.h:561:26: error: 'auto' not allowed in template parameter until C++17
...
/usr/include/unicode/uenum.h:69:69: error: value of type 'void (UEnumeration *)' is not implicitly convertible to 'int'
...

@mtxn2147
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msftrubengu msftrubengu Awaiting requested review from msftrubengu msftrubengu is a code owner

@ranm-msft ranm-msft Awaiting requested review from ranm-msft ranm-msft is a code owner

@JohnMcPMS JohnMcPMS Awaiting requested review from JohnMcPMS JohnMcPMS is a code owner

@sachinkumar-2106 sachinkumar-2106 Awaiting requested review from sachinkumar-2106 sachinkumar-2106 is a code owner

@kyelamarthi1 kyelamarthi1 Awaiting requested review from kyelamarthi1 kyelamarthi1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtxn2147