Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make box smaller for no pbc structure #84

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

anyangml
Copy link
Contributor

This PR aims to solve the issue mentioned in #82. When running inference on no-pbc structures, an artificial box is created and the no-pbc structure is converted to pbc structure. However, the original design gives an unnecessarily large box, which leads to data loading bottleneck due to find_points_in_spheres function. The GPU usage is almost zero. I provided a fix by using a smaller box. The test results are mentioned in #82 .

@yanghan234 yanghan234 self-requested a review February 5, 2025 04:07
@yanghan234
Copy link
Collaborator

Hi @anyangml, thanks for the contribution and sorry for the delay. Would you please apply the patch that I suggested in the comment above? I reproduced the problem that you raised in #82. It seems that we need a better way to handle isolated systems instead of using the extremely large cell. But, your fix is good enough for the moment. Thank you!

@anyangml
Copy link
Contributor Author

anyangml commented Feb 5, 2025

@anyangml please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@anyangml anyangml requested a review from yanghan234 February 5, 2025 04:27
@anyangml anyangml requested a review from yanghan234 February 5, 2025 05:06
@yanghan234 yanghan234 merged commit f1028e5 into microsoft:main Feb 5, 2025
20 checks passed
@yanghan234
Copy link
Collaborator

Merged! Thanks for your interest in MatterSim and your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants