Recognize json as plain text (if no other handlers are present). #261
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #34 by adding the
application/jsonmimetype to the PlainTextConverter.Arguably many other types should be added... and perhaps we should accept anything that looks like UTF-8 or similar.
Note: We may want to render json more directly in the future (#251, #219, etc), but for now, this is a good stopgap that corrects a behavior that was intended, but broken. We can add more sophisticated converters by simply placing them in higher priority when registering them. PlainTextConverter should always be the last resort and a good fallback when no other converters are available.