Add a trace interface to enable ignoring MOF events #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOF events all require a (slow) TDH lookup which can fail if schema is not available. Since these are generally legacy events, many applications may not require them and ignoring them can provide a significant performance increase, particularly for large trace files.
|
Ignoring MOF events for some ETL traces provide orders of magnitudes speed improvements. Real Example: ~500MB ETL trace is parsed in 146s with MOF events -> 6s without MOF events. Problem seems rooted in that reading from an ETL file does not seem to obey event filters, making it possible for undesired events to be read in regardless of provider filter settings. |
swannman
reviewed
May 8, 2023
| * trace.set_ignore_mof_events(true); | ||
| * </example> | ||
| */ | ||
| void set_ignore_mof_events(bool ignore_mof_events); |
There was a problem hiding this comment.
Let's call this set_mof_event_processing_enabled(bool mof_events_enabled) with a default of true to avoid a double-negative.
| @@ -308,6 +322,8 @@ namespace krabs { | |||
|
|
|||
| provider_callback default_callback_ = nullptr; | |||
|
|
|||
| bool ignore_mof_events_ = false; | |||
|
@acyr We're happy to merge this pending the feedback above. Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOF events all require a (slow) TDH lookup which can fail if schema is not available. Since these are generally legacy events, many applications may not require them and ignoring them can provide a significant performance increase, particularly for large trace files.