Skip to content

Commit

Permalink
Remove unnecessary E2E test, and add skip_validations flag to cli
Browse files Browse the repository at this point in the history
  • Loading branch information
AlonsoGuevara committed Aug 20, 2024
1 parent 6682f14 commit 630ea02
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 16 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/python-smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,3 @@ jobs:
with:
name: smoke-test-artifacts-${{ matrix.python-version }}-${{ matrix.poetry-version }}-${{ runner.os }}
path: tests/fixtures/*/output

- name: E2E Test
if: steps.changes.outputs.python == 'true'
run: |
./scripts/e2e-test.sh
- uses: actions/upload-artifact@v4
if: always()
with:
name: e2e-test-artifacts-${{ matrix.python-version }}-${{ matrix.poetry-version }}-${{ runner.os }}
path: examples/*/output
6 changes: 6 additions & 0 deletions graphrag/index/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@
help="Overlay default configuration values on a provided configuration file (--config).",
action="store_true",
)
parser.add_argument(
"--skip-validations",
help="Skip any preflight validation. Useful when running no LLM steps.",
action="store_true",
)
args = parser.parse_args()

if args.overlay_defaults and not args.config:
Expand All @@ -85,4 +90,5 @@
dryrun=args.dryrun or False,
init=args.init or False,
overlay_defaults=args.overlay_defaults or False,
skip_validations=args.skip_validations or False,
)
4 changes: 3 additions & 1 deletion graphrag/index/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ def index_cli(
emit: str | None,
dryrun: bool,
overlay_defaults: bool,
skip_validations: bool,
):
"""Run the pipeline with the given config."""
progress_reporter = load_progress_reporter(reporter or "rich")
Expand Down Expand Up @@ -154,7 +155,8 @@ def index_cli(
True,
)

validate_config_names(progress_reporter, default_config)
if skip_validations:
validate_config_names(progress_reporter, default_config)

info(f"Starting pipeline run for: {run_id}, {dryrun=}", verbose)
info(
Expand Down
4 changes: 0 additions & 4 deletions scripts/e2e-test.sh

This file was deleted.

0 comments on commit 630ea02

Please sign in to comment.