Fill in .gdnsuppress to fix internal build #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more entries to
.config/guardian/.gdnsuppress
to match the current list of false positive credscan detections.We are set up to use the TSA service to automatically use AzDO work items to handle credscan suppression, but it doesn't seem to be working now. In the past, there has also been an outage where work items weren't created, so we had to use the suppression file to unblock our builds. I think we should stop depending on the TSA workflow and instead simply update the
.config/guardian/.gdnsuppress
all the time. This way, we get rid of the seemingly fragile TSA dependency and avoid time spent diagnosing issues with it.Closing AzDO work items in the right way to suppress issues is also, in my opinion, fiddlier than it needs to be, time consuming, and has a more difficult historical trail to follow than commits to a file do.
If a build hits credscan issues, it produces a suppressions file here:
As of writing, that file contains a warning:
Getting a setup working to dehydrate the file is tedious and is a reason I've avoided this process in the past. However, I checked with the 1ES PT team and they are talking with the Guardian team to update this message. It is safe to check the hydrated file into the repo:
https://teams.microsoft.com/l/message/19:[email protected]/1734637010168?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=886b1d22-e648-4492-af5f-6fbe81e73d4a&parentMessageId=1734637010168&teamName=1ES%20Pipeline%20Templates%20(1ES%20PT)&channelName=Support%20-%20General&createdTime=1734637010168
The 1ES PT team is contacting the Guardian team to get that message updated.
So, the new workflow to resolve a false positive and unblock the build is to grab that artifact and submit a PR with its
results
copied into this file.I don't know yet whether a TSA-opened work item associated with a false positive will automatically be closed when the PR is merged and an internal build runs on the result. (I'm hoping so. But it won't block our build if they don't, and we can address that later.)
Test internal build that passed with this PR: https://dev.azure.com/dnceng/internal/_build/results?buildId=2605810&view=results