Remove crypto/internal/boring/fipstls dependency from crypto/internal/backend
#1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
microsoft-golang-review-bot and
a team
as code owners
qmuntal
changed the title
crypto/internal/boring/fipstls dependency from crypto/internal/backend
dagood
requested changes
Dec 12, 2024
qmuntal
force-pushed
the
dev/qmuntal/fips140tls
branch
2 times, most recently
from
430fc00 to
8acf042
Compare
All missing pieces have been added. |
gdams
approved these changes
Dec 16, 2024
qmuntal
force-pushed
the
dev/qmuntal/fips140tls
branch
from
05453f5 to
59dc384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Review ignoring whitespaces)
Upstream refactored the fipstls logic to support the new built-in FIPS module. This is causing many conflicts in the upstream sync PR.
This PR moved the logic that detects whether FIPS mode is required or not (e.g. setting the
GOFIPSenv var) to its own package that only depends onsyscall. This way we can easily import it elsewhere, for example incrypto/internal/boring/fipstlsand makecrypto/internal/backendnot depend on the former. Doing so will greatly simplify reconciling the conflicts in the upstream sync PR.The refactor shouldn't change any behavior.
For #1416.
For #1383.