Minimize TLS PRF upstream diffs #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
microsoft-golang-review-bot and
a team
as code owners
gdams
approved these changes
Dec 12, 2024
dagood
approved these changes
Dec 13, 2024
qmuntal
force-pushed
the
dev/qmuntal/prfnoerr
branch
from
71cbd38 to
fa08c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream did an importat refactor in the
crypto/tls/prf.gofile that produces a lot of conflicts in our patches. The main issue is that usptream PRF functions don't return an error, while the ones implemented on our backend do. Passing the error up means changing many signatures and call sites.This PR reduces these future conflicts by panicking instead of returning an error. We then keep the previous behavior by recovering from the panic (if there is one) and lowering the panic into an error.
For #1416.
For #1383.