Update .gdnsuppress #1249
Merged
Update .gdnsuppress #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
requested review from
microsoft-golang-review-bot and
a team
as code owners
gdams
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/mainis failing due to CredScan, but we haven't received a task from TSA (yet?) so we can't suppress it the usual way. To generate this PR I:guardian.cmd initdrop_sdl_sources/SDL Sources Analysis (self)/.gdnsuppressto.config\guardian\.gdnsuppressguardian.cmd dehydrate -s C:\git\go\.config\guardian\.gdnsuppress(full path: guardian working dir is.gdn!)guardian.cmd deinit --confirmI suspect that the old suppressions aren't showing up because we've addressed them in TSA work items.
Test build with this update: https://dev.azure.com/dnceng/internal/_build/results?buildId=2470349&view=results