Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -d=dclstack compiler flag for ssacheck builder #1200

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Apr 10, 2024

Our outerloop sshacheck builder have been consistently failing for a year (e.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2426158&view=logs&s=e08da66d-f904-5a02-d622-d38459b08878) because it sets the -d=dclstack argument when invoking the Go toolchain, but that argument was removed in https://go-review.googlesource.com/c/build/+/463775.

We should check outerloop builders more often...

@qmuntal qmuntal requested review from dagood and gdams April 10, 2024 08:26
@qmuntal qmuntal requested a review from a team as a code owner April 10, 2024 08:26
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A long while ago I set up https://dev.azure.com/dnceng/internal/_dashboards/dashboard/9371d09b-76a4-41d7-b287-7ba66cd4928a to try to keep an eye on it without loud noise like emails. I think it suffered the usual fate of flakiness on a low priority pipeline: it wasn't worth checking and confirming every single failure was flakiness, but it also wasn't worth filtering out flakiness or turning off specific tests, so it ended up ignored.

Now that we're far enough that we're working on scenario tests, it makes sense to me that getting this part of the house cleaned up (and keeping it that way) might have enough priority.

@dagood dagood merged commit d554f76 into microsoft/main Apr 12, 2024
23 checks passed
@dagood dagood deleted the dev/qmuntal/ssacheck branch April 12, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants