Support TLS 1.3 in fipstls mode #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
a team and
microsoft-golang-review-bot
as code owners
dagood
approved these changes
Jan 30, 2024
| + return VersionTLS13 | ||
| } | ||
|
|
||
| // default defaultFIPSCurvePreferences is the FIPS-allowed curves, |
There was a problem hiding this comment.
In the var here, var defaultFIPSCurvePreferences = []CurveID{CurveP256, CurveP384, CurveP521}, the CurveP521 entry is still there--this is good, per golang/go#62372 (comment).
(Just taking a note on what's different here vs. the reverted upstream changes.)
Also go1.20/go1.21, right? (Although it's only practical to actually do it once golang/go#65322 and golang/go#65323 get merged.) |
gdams
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TLS 1.3 when running in fipstls mode.
The changes have been taken from https://go-review.googlesource.com/c/go/+/558796 and put in its own patch file so they are easier to revert once upstream finally support TLS 1.3 in fipstls mode.
This will have to be ported to the go1.22 release branch.
Updates #1119.