Add ms.tlsfipsonly tag to reduce source changes
#1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
requested review from
a team and
microsoft-golang-review-bot
as code owners
gdams
approved these changes
Jan 24, 2024
qmuntal
approved these changes
Jan 25, 2024
|
After some more internal discussion, we don't think this is enough to actually address our needs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first
ms.prefix, but I've been thinking we should use one for a while: #999 (comment). If upstream added atlsfipsonlytag, it may work differently, and this helps us be prepared for that.For now I wrote that it's in 1.23 since that's what
mainis right now, but we might want to put it in 1.22.This is a very simple feature--a lot of this PR is for the error checking and writing up the usage in the FIPS doc.
Doc preview: https://github.com/microsoft/go/blob/dev/dagood/fipsonly-tag/eng/doc/fips/README.md