Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to latest master in microsoft/main #1082

Closed

Conversation

microsoft-golang-bot
Copy link
Collaborator

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 3 times, most recently from 0ae1c4b to 482c6cd Compare November 17, 2023 16:04
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 4 times, most recently from cff1717 to 9d554ff Compare November 27, 2023 16:02
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch from 9d554ff to 3af002a Compare November 29, 2023 17:07
@dagood
Copy link
Member

dagood commented Nov 29, 2023

This update seems to be consistently causing this test failure on (specifically!) our windows-amd64 cngcrypto builders:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=481222&view=ms.vss-test-web.build-test-results-tab&runId=11052014&resultId=100890&paneView=debug

=== RUN   TestCallbackCallersSEH
    callback_windows.go:131: incorrect backtrace:
        want:	[runtime.asmcgocall_landingpad runtime.asmcgocall runtime.cgocall test._Cfunc_backtrace test.testCallbackCallersSEH.func1.1 test.testCallbackCallersSEH.func1 test.goCallback _cgoexp_goCallback runtime.cgocallbackg1 runtime.cgocallbackg runtime.cgocallbackg runtime.cgocallback crosscall2 runtime.asmcgocall_landingpad runtime.asmcgocall runtime.cgocall test._Cfunc_callback test.nestedCall.func1 test.nestedCall test.testCallbackCallersSEH test.TestCallbackCallersSEH testing.tRunner testing.(*T).Run.gowrap3 runtime.goexit]
        got:	[runtime.asmcgocall_landingpad runtime.asmcgocall runtime.cgocall]
--- FAIL: TestCallbackCallersSEH (0.00s)

=== FAIL: cmd/cgo/internal/test:internal TestCallbackCallersSEH (0.00s)

@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 4 times, most recently from 0eff80c to 2e406d9 Compare December 8, 2023 16:02
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 3 times, most recently from 7063a2b to 6b4c9f2 Compare December 15, 2023 16:02
@dagood dagood force-pushed the dev/auto-sync/microsoft/main branch from 6b4c9f2 to 7063a2b Compare December 15, 2023 17:30
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch from 7063a2b to 38f8dc3 Compare December 18, 2023 16:02
@dagood dagood closed this Dec 19, 2023
auto-merge was automatically disabled December 19, 2023 23:37

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants