Code

Implement Timeouts For Lua Scripts#983

Code

Open

kevin-montrose wants to merge 24 commits intomainmicrosoft/garnet:mainfrom luaTimeLimitsmicrosoft/garnet:luaTimeLimitsCopy head branch name to clipboard

+1,091-56

Commits

Commits on Jan 29, 2025

• add --lua-script-timeout option; doesn't do anything yet

  kevin-montrose

  committed
  e54abec

  Copy full SHA for e54abec

• sketch out timeouts

  kevin-montrose

  committed
  71ad6f5

  Copy full SHA for 71ad6f5

• basic timeouts tested with LuaRunners

  kevin-montrose

  committed
  624ace1

  Copy full SHA for 624ace1

• enforce timeouts for session run scripts as well

  kevin-montrose

  committed
  4387cfa

  Copy full SHA for 4387cfa

• add a (perhaps temporary?) benchmark for when timeouts are enabled; not surprisingly there's a bunch of overhead

  kevin-montrose

  committed
  a4f9e1c

  Copy full SHA for a4f9e1c

• stopgap commit; a creating a new timer on each invocation is too slow and expensive, so sketch out an on-demand option

  kevin-montrose

  committed
  c5fec6d

  Copy full SHA for c5fec6d

• fill out implementation for common timer for all script timeouts, lockless; there's some finese in the concurrency around Lua, but the Debug interfaces are threadsafe; all tests passing; still need…

  Show description for 25ad19b
  kevin-montrose

  committed
  25ad19b

  Copy full SHA for 25ad19b

Commits on Jan 30, 2025

• another pass at a lockless implementation; less futzing with linked lists and whatnot, since sessions script is already synchronized

  kevin-montrose

  committed
  4014cdc

  Copy full SHA for 4014cdc

• rework LuaParams and update LuaTimeouts to run the full server

  kevin-montrose

  committed
  f9531ed

  Copy full SHA for f9531ed

• cleanup

  kevin-montrose

  committed
  ae793bd

  Copy full SHA for ae793bd

• add a stress test (disabled by default) for timeouts

  kevin-montrose

  committed
  e467a82

  Copy full SHA for e467a82

• just some general cleanup and nits

  kevin-montrose

  committed
  c811952

  Copy full SHA for c811952

• Merge branch 'main' into luaTimeLimits

  kevin-montrose

  committed
  55e7435

  Copy full SHA for 55e7435

• tons of variance, lets kick this up to 100+ms

  kevin-montrose

  committed
  b086570

  Copy full SHA for b086570

Commits on Jan 31, 2025

• remove some interlocked ops and other constructs that, at least on x86 (:/), are unnecessary

  kevin-montrose

  committed
  1336163

  Copy full SHA for 1336163

• micro ops to claw some perf back

  kevin-montrose

  committed
  48800d9

  Copy full SHA for 48800d9

• speed up the common case of ScriptHashKey lookups

  kevin-montrose

  committed
  28f75ce

  Copy full SHA for 28f75ce

• EVALSHA is a 'slow' command, so a non-trivial amount of time is spent attempting to upper case the command; speed that up to claw back some of the timeout overhead

  kevin-montrose

  committed
  28e1129

  Copy full SHA for 28e1129

Commits on Feb 3, 2025

• formatting

  kevin-montrose

  committed
  72f7718

  Copy full SHA for 72f7718

• Merge branch 'main' into luaTimeLimits

  kevin-montrose

  authored
  d811ac0

  Copy full SHA for d811ac0

• Merge branch 'main' into luaTimeLimits

  kevin-montrose

  authored
  79d0127

  Copy full SHA for 79d0127

Commits on Feb 5, 2025

• Merge branch 'main' into luaTimeLimits

  kevin-montrose

  authored
  235fd1d

  Copy full SHA for 235fd1d

• fix merge and formatting

  kevin-montrose

  committed
  97070fb

  Copy full SHA for 97070fb

Commits on Feb 6, 2025

• Merge branch 'main' into luaTimeLimits

  kevin-montrose

  authored
  9544d5e

  Copy full SHA for 9544d5e