Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of start-up script to download tes_vm_perf.tgz and execute bootstrapper #622

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

jlester-msft
Copy link
Contributor

@jlester-msft jlester-msft commented Feb 27, 2024

No description provided.

jlester-msft and others added 28 commits February 27, 2024 15:30
…pload the log to the storage account task dir
… confusing bash. remove extra spaces to avoid

$'\r': command not found errors
Upload debug information using single azcopy on error only
add notes for making setup of vm_monitor work in the start task
@@ -0,0 +1,13 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JL to delete

@MattMcL4475
Copy link
Collaborator

MattMcL4475 commented Mar 25, 2024

TODO:

  • 1. Add configuration setting; something like AdvancedVmPerformanceMonitoringEnabled; default false to the "BatchNodes" area
  • 2. Move the download to the start task
  • 3. Merge origin/main into this branch

@BMurri BMurri changed the title Update of start-up script to download tes_vm_perf.tgz and execute boo… Update of start-up script to download tes_vm_perf.tgz and execute bootstrapper Mar 25, 2024
@BMurri BMurri added the Needs Issue PR needs at least one associated issue label Mar 26, 2024
@BMurri
Copy link
Collaborator

BMurri commented Apr 15, 2024

I'd prefer if we could build the binary download packages in the build rather than check those binaries into git

Update dockerfile caching
Update telegraf configs with better timestamp behavior and collection cleanup
@jlester-msft
Copy link
Contributor Author

I'd prefer if we could build the binary download packages in the build rather than check those binaries into git

Agreed this would need some integration into the build pipeline to generate the binary package.

Right now src/vm_monitor/build_tes_deployment_archive.sh contains an example script that will do the building of the telegraf binary + build a .tar.gz of everything. The basic steps are:

  1. Build a custom stripped down version of telegraf
    1. The local build process should probably be skipped in favor of the docker style build in src/vm_monitor/build_telegraf_remote.sh. This is setup to build on a remote VM but doesn't need to. It is basically dockerfile build + run the docker to copy out the telegraf binary
  2. Make a flattened .tar.gz file with the binary + the scripts needed
  3. Put that binary somewhere consumable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Issue PR needs at least one associated issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants