[WIP] Add OIDC multi-provider auth #446
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMcL4475
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple concurrently-configured OpenID Connect providers, such as Azure AD, AWS Cognito, Google Identity. Also the
principal_ididentifies the service principal object associated with a Managed Identity in Azure AD, and it corresponds to theObject ID(oid) claim in the JWT token. As a result, when Cromwell calls TES, TES could use theoidand use it to specify the user-managed identity that should be assigned to the Batch pool. Another possibility -SaveTokenscan be set to true, and then theClaimsPrincipalwill have claims that can be used for TES to make authorized requests to Azure Storage on the user's behalf (but would require injecting the token from TES into the Batch node, so might not be as simple as oid)Then this branch adds multi-user support:
#447