Handle database overloads and return 429 #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMurri
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Looks ok to me, except I'm starting to get eyestrain, so you may wish to wait for @giventocode to weigh in.
BMurri
reviewed
May 12, 2023
| @@ -0,0 +1,42 @@ | |||
| namespace TesApi.Web | |||
There was a problem hiding this comment.
I'd suggest moving this file to the Controllers folder, since that's the only context in which this code will ever operate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the database is overloaded (timeouts, connection pool exhaustion), this PR uses global middleware exception handling to return 429 (too many requests) to the caller. #228