[hackathon-2024]: Add Component Selector to storybook #32865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…msamec/fluentui into adamsamec/component-selector
…Switched to using mdx stories to keep design as per the rest of the portal | Alligned Styling to be consistent with portal and cople of design changes
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 652 | 624 | 5000 | |
| Button | mount | 298 | 302 | 5000 | |
| Field | mount | 1117 | 1142 | 5000 | |
| FluentProvider | mount | 697 | 710 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 35 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 89 | 10 | |
| MakeStyles | mount | 887 | 881 | 50000 | |
| Persona | mount | 1802 | 1719 | 5000 | |
| SpinButton | mount | 1386 | 1377 | 5000 | |
| SwatchPicker | mount | 1683 | 1661 | 5000 |
fabricteam
reviewed
Sep 19, 2024
| @@ -0,0 +1,614 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 11 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 21 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 1139 | Changed |
| Drawer.Full Overlay High Contrast.chromium.png | 4926 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As a 2024 hackathon project, this PR adds the improved version of Component Selector into the storybook. Component Selector is a tool in beta state for developrs and designers that aims to ease the descision process when choosing the right Fluent UI v9 component.
The beta version of Component Selector can be tested here.
Note: Not intended for merge yet
Right now, Component Selector added by this PR is intended only for development and presentation, so the PR is not meant for merge yet.