Virtualizer: Optimize IO usage and export useMeasureList #32375
+685
−393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 40 | 32 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 610 | 661 | 5000 | |
| Button | mount | 328 | 302 | 5000 | |
| Field | mount | 1135 | 1116 | 5000 | |
| FluentProvider | mount | 731 | 702 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 40 | 32 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 75 | 10 | |
| MakeStyles | mount | 867 | 888 | 50000 | |
| Persona | mount | 1760 | 1689 | 5000 | |
| SpinButton | mount | 1382 | 1381 | 5000 | |
| SwatchPicker | mount | 1661 | 1676 | 5000 |
fabricteam
reviewed
Aug 23, 2024
change/@fluentui-react-virtualizer-bab73d05-7372-4052-8d22-ca75b5fadfe2.json
Show resolved
Hide resolved
Mitch-At-Work
changed the title
Mitch-At-Work
force-pushed
the
user/mifraser/export-virtualizer-helpers
branch
3 times, most recently
from
3894a66
to
429d65a
Compare
Mitch-At-Work
force-pushed
the
user/mifraser/export-virtualizer-helpers
branch
from
0c84cd4
to
edd7073
Compare
Mitch-At-Work
commented
Sep 3, 2024
packages/react-components/react-virtualizer/library/src/hooks/useMeasureList.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
commented
Sep 3, 2024
...ges/react-components/react-carousel-preview/stories/src/Carousel/CarouselDefault.stories.tsx
Outdated
Show resolved
Hide resolved
...s/react-components/react-virtualizer/library/src/components/Virtualizer/Virtualizer.types.ts
Show resolved
Hide resolved
...ages/react-components/react-virtualizer/library/src/components/Virtualizer/useVirtualizer.ts
Show resolved
Hide resolved
...ages/react-components/react-virtualizer/library/src/components/Virtualizer/useVirtualizer.ts
Show resolved
Hide resolved
brandonthomas
approved these changes
Sep 6, 2024
bsunderhus
requested changes
Sep 23, 2024
There was a problem hiding this comment.
There's a breaking change in this PR by introducing the containerSizeRef as a required property to the Virtualizer component.
Also, I'd like to understand better what is happening here, so I'll take a bit of time to review properly, at the moment I'm blocking it as it introduces a breaking change and there's no warnings about it in the PR.
...s/react-components/react-virtualizer/library/src/components/Virtualizer/Virtualizer.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-virtualizer/library/src/hooks/useVirtualizerMeasure.ts
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Mitch-At-Work
added
Needs: Behavior Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: Additional info was required to be shared between hooks, this added new properties to our hook inputs which are required for accurate calculation of IO depth (Virtualizer is still in old preview format)
Previous Behavior
useMeasureList was not exported
IO would iterate based on it's current position
New Behavior
useMeasureList is now exported
IO now iterates based on how far into the IO the user scrolls, cutting down re-renders significantly