chore: use @wyw-in-js/transform #30992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Apr 8, 2024
Comment on lines
+37
to
+39
| const asyncResolve: AsyncResolve = async (what, importer, stack) => { | ||
| return require.resolve(what, { paths: [importer] }); | ||
| }; |
There was a problem hiding this comment.
This should be replaced with a proper resolved using path aliases.
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 674 | 652 | 5000 | |
| Button | mount | 298 | 311 | 5000 | |
| Field | mount | 1131 | 1163 | 5000 | |
| FluentProvider | mount | 703 | 739 | 5000 | |
| FluentProviderWithTheme | mount | 89 | 94 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 34 | 39 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 81 | 10 | |
| MakeStyles | mount | 849 | 888 | 50000 | |
| Persona | mount | 1774 | 1764 | 5000 | |
| SpinButton | mount | 1393 | 1385 | 5000 |
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| PortalMinimalPerf.default | 84 | 85 | 0.99:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 115 | 96 | 1.2:1 |
| AttachmentMinimalPerf.default | 88 | 74 | 1.19:1 |
| ChatDuplicateMessagesPerf.default | 169 | 148 | 1.14:1 |
| LoaderMinimalPerf.default | 199 | 184 | 1.08:1 |
| RefMinimalPerf.default | 114 | 106 | 1.08:1 |
| CarouselMinimalPerf.default | 270 | 252 | 1.07:1 |
| ButtonMinimalPerf.default | 91 | 86 | 1.06:1 |
| TextMinimalPerf.default | 197 | 185 | 1.06:1 |
| ImageMinimalPerf.default | 220 | 210 | 1.05:1 |
| MenuMinimalPerf.default | 511 | 486 | 1.05:1 |
| ProviderMinimalPerf.default | 206 | 196 | 1.05:1 |
| SegmentMinimalPerf.default | 201 | 192 | 1.05:1 |
| TextAreaMinimalPerf.default | 293 | 279 | 1.05:1 |
| AccordionMinimalPerf.default | 83 | 80 | 1.04:1 |
| FlexMinimalPerf.default | 152 | 146 | 1.04:1 |
| HeaderMinimalPerf.default | 217 | 209 | 1.04:1 |
| TreeMinimalPerf.default | 484 | 466 | 1.04:1 |
| BoxMinimalPerf.default | 195 | 189 | 1.03:1 |
| ChatWithPopoverPerf.default | 201 | 196 | 1.03:1 |
| InputMinimalPerf.default | 540 | 522 | 1.03:1 |
| SkeletonMinimalPerf.default | 212 | 205 | 1.03:1 |
| ButtonOverridesMissPerf.default | 654 | 640 | 1.02:1 |
| HeaderSlotsPerf.default | 476 | 467 | 1.02:1 |
| ListNestedPerf.default | 317 | 312 | 1.02:1 |
| ReactionMinimalPerf.default | 209 | 205 | 1.02:1 |
| StatusMinimalPerf.default | 395 | 387 | 1.02:1 |
| TooltipMinimalPerf.default | 1293 | 1272 | 1.02:1 |
| AlertMinimalPerf.default | 160 | 158 | 1.01:1 |
| CardMinimalPerf.default | 311 | 309 | 1.01:1 |
| ChatMinimalPerf.default | 435 | 430 | 1.01:1 |
| DialogMinimalPerf.default | 448 | 442 | 1.01:1 |
| PopupMinimalPerf.default | 347 | 344 | 1.01:1 |
| TableManyItemsPerf.default | 1113 | 1106 | 1.01:1 |
| AttachmentSlotsPerf.default | 628 | 630 | 1:1 |
| CheckboxMinimalPerf.default | 1136 | 1133 | 1:1 |
| DropdownMinimalPerf.default | 1452 | 1457 | 1:1 |
| FormMinimalPerf.default | 225 | 226 | 1:1 |
| GridMinimalPerf.default | 192 | 192 | 1:1 |
| ItemLayoutMinimalPerf.default | 704 | 706 | 1:1 |
| ListMinimalPerf.default | 301 | 301 | 1:1 |
| MenuButtonMinimalPerf.default | 947 | 945 | 1:1 |
| IconMinimalPerf.default | 400 | 401 | 1:1 |
| TableMinimalPerf.default | 237 | 236 | 1:1 |
| AnimationMinimalPerf.default | 296 | 299 | 0.99:1 |
| ButtonSlotsPerf.default | 317 | 320 | 0.99:1 |
| DatepickerMinimalPerf.default | 3522 | 3564 | 0.99:1 |
| EmbedMinimalPerf.default | 1878 | 1895 | 0.99:1 |
| LayoutMinimalPerf.default | 200 | 202 | 0.99:1 |
| RadioGroupMinimalPerf.default | 261 | 264 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2202 | 2232 | 0.99:1 |
| CustomToolbarPrototype.default | 1471 | 1483 | 0.99:1 |
| LabelMinimalPerf.default | 216 | 221 | 0.98:1 |
| ListCommonPerf.default | 388 | 397 | 0.98:1 |
| ProviderMergeThemesPerf.default | 648 | 664 | 0.98:1 |
| SliderMinimalPerf.default | 721 | 733 | 0.98:1 |
| DividerMinimalPerf.default | 198 | 204 | 0.97:1 |
| DropdownManyItemsPerf.default | 388 | 399 | 0.97:1 |
| ToolbarMinimalPerf.default | 530 | 545 | 0.97:1 |
| RosterPerf.default | 1524 | 1620 | 0.94:1 |
| ListWith60ListItems.default | 356 | 383 | 0.93:1 |
| VideoMinimalPerf.default | 413 | 443 | 0.93:1 |
| TreeWith60ListItems.default | 73 | 85 | 0.86:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 632 | 610 | 5000 | |
| Breadcrumb | mount | 1690 | 1653 | 1000 | |
| Checkbox | mount | 1654 | 1672 | 5000 | |
| CheckboxBase | mount | 1460 | 1434 | 5000 | |
| ChoiceGroup | mount | 2916 | 2912 | 5000 | |
| ComboBox | mount | 639 | 649 | 1000 | |
| CommandBar | mount | 6219 | 6127 | 1000 | |
| ContextualMenu | mount | 11601 | 11837 | 1000 | |
| DefaultButton | mount | 757 | 714 | 5000 | |
| DetailsRow | mount | 2202 | 2187 | 5000 | |
| DetailsRowFast | mount | 2176 | 2192 | 5000 | |
| DetailsRowNoStyles | mount | 2059 | 1989 | 5000 | |
| Dialog | mount | 2820 | 2665 | 1000 | |
| DocumentCardTitle | mount | 216 | 222 | 1000 | |
| Dropdown | mount | 2001 | 2000 | 5000 | |
| FocusTrapZone | mount | 1143 | 1132 | 5000 | |
| FocusZone | mount | 1088 | 1084 | 5000 | |
| GroupedList | mount | 41280 | 41398 | 2 | |
| GroupedList | virtual-rerender | 19977 | 19743 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50770 | 50712 | 2 | |
| GroupedListV2 | mount | 229 | 236 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 207 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 226 | 228 | 2 | |
| IconButton | mount | 1099 | 1068 | 5000 | |
| Label | mount | 334 | 330 | 5000 | |
| Layer | mount | 2735 | 2739 | 5000 | |
| Link | mount | 386 | 389 | 5000 | |
| MenuButton | mount | 932 | 964 | 5000 | |
| MessageBar | mount | 21380 | 21295 | 5000 | |
| Nav | mount | 1939 | 1962 | 1000 | |
| OverflowSet | mount | 769 | 759 | 5000 | |
| Panel | mount | 1814 | 1781 | 1000 | |
| Persona | mount | 722 | 736 | 1000 | |
| Pivot | mount | 867 | 898 | 1000 | |
| PrimaryButton | mount | 834 | 850 | 5000 | |
| Rating | mount | 4612 | 4626 | 5000 | |
| SearchBox | mount | 912 | 906 | 5000 | |
| Shimmer | mount | 1903 | 1891 | 5000 | |
| Slider | mount | 1318 | 1314 | 5000 | |
| SpinButton | mount | 2867 | 2903 | 5000 | |
| Spinner | mount | 392 | 397 | 5000 | |
| SplitButton | mount | 1927 | 1840 | 5000 | |
| Stack | mount | 414 | 416 | 5000 | |
| StackWithIntrinsicChildren | mount | 867 | 846 | 5000 | |
| StackWithTextChildren | mount | 2599 | 2613 | 5000 | |
| SwatchColorPicker | mount | 6210 | 6228 | 5000 | |
| TagPicker | mount | 1480 | 1464 | 5000 | |
| Text | mount | 374 | 373 | 5000 | |
| TextField | mount | 952 | 929 | 5000 | |
| ThemeProvider | mount | 833 | 822 | 5000 | |
| ThemeProvider | virtual-rerender | 574 | 579 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1262 | 1289 | 5000 | |
| Toggle | mount | 611 | 617 | 5000 | |
| buttonNative | mount | 185 | 198 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@griffel/reactto latest (current version does not have definedtagsinpackage.json(chore(react): add "wyw-in-js" field for tag processor griffel#475)@wyw-in-js/transform&@griffel/tag-processor(actual transform)TODOs