Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore(xplat): Hook up Dropdown to cross-platform-adapter #30981

Closed
wants to merge 6 commits into from
Closed

[WIP] chore(xplat): Hook up Dropdown to cross-platform-adapter #30981

wants to merge 6 commits into from

Conversation

behowell
Copy link
Contributor

@behowell behowell commented Apr 6, 2024 •
edited
Loading

ℹ️ Note this is being merged into the xplat branch, not master.

New Behavior

This PR is still a work in progress.

  • Hook up Dropdown and related components from react-combobox to the react-platform-adapter.
  • Add an example Dropdown to xplat-v9.
  • Suppress known warnings about unsupported warnings in convertGriffelToStyleX.
  • Fix errors in useActiveDescendant from lack of support for setAttribute in RSD.

TODO

  • Positioning is not working; the dropdown popover is not appearing.

@behowell behowell self-assigned this Apr 6, 2024
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 6, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@layershifter
Copy link
Member

Closing for housekeeping 🏡 Feel free to re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work Mitch-At-Work will be requested when the pull request is marked ready for review Mitch-At-Work is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto will be requested when the pull request is marked ready for review khmakoto is a code owner

@marcosmoura marcosmoura Awaiting requested review from marcosmoura marcosmoura will be requested when the pull request is marked ready for review marcosmoura is a code owner

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT will be requested when the pull request is marked ready for review GeoffCoxMSFT is a code owner

@tomi-msft tomi-msft Awaiting requested review from tomi-msft tomi-msft will be requested when the pull request is marked ready for review tomi-msft is a code owner

@sopranopillow sopranopillow Awaiting requested review from sopranopillow sopranopillow will be requested when the pull request is marked ready for review sopranopillow is a code owner

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt micahgodbolt will be requested when the pull request is marked ready for review micahgodbolt is a code owner

@smhigley smhigley Awaiting requested review from smhigley smhigley will be requested when the pull request is marked ready for review smhigley is a code owner

Assignees

@behowell behowell

Labels
Area: Cross-Platform React
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@behowell @layershifter @kelset