Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xplat-v9): adding a webapp to test the code, and cleanups #30977

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

kelset
Copy link

@kelset kelset commented Apr 5, 2024

ℹ️ Note: This is being merged into the xplat branch, not master

Description

This PR does a couple of things:

  1. it adds a new small web app under the web folder. This mimiks something we've done in the past for other xplat projects (see here) and allows to verify that the code works directly on both the native platforms and web. (see screenshots below)
  2. it cleans up the code a bit, removing unused code.

While working on this code, I've hit two different issues:

  • on mobile (iOS and Android), the layout is not respected. Despite the StrictDomDemo being wrapped in a View it goes outside its boundaries (you can see it in the screenshot). This needs to get investigated & fixed separately.
  • on Android, one of the Buttons, Shape to be precise, crashes the app with the error: Error while updating property 'borderBottomRightRadius' of a view managed by: RCTView java.lang.String cannot be cast to java.lang.Double - this one also needs to be investigated separately, for now I've commented that specific button out.

Screenshot

Here's the code working across iOS-Android-macOS-web:

Screenshot 2024-04-05 at 11 30 01

And here's a quick GIF showing that it's literally the same code:

Apr-05-2024 11-22-55

Copy link

codesandbox-ci bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@kelset kelset merged commit 04cdd7b into microsoft:xplat Apr 8, 2024
13 checks passed
@kelset kelset deleted the kelset/add-webapp branch April 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants