chore(xplat): Rename package to react-platform-adapter-preview and mark as public #30826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behowell
requested review from
a team,
sopranopillow,
micahgodbolt,
khmakoto,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
JustSlone
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Note: This is being merged into the
xplatbranch, notmaster. The package will not be published until if/when it is merged tomaster.Previous Behavior
The
react-platform-adapterpackage was marked as private but was being consumed by public packages, which was causing a CI failure. Additionally, the package wasn't following the-previewnaming convention for non-stable packages.New Behavior
Rename the package to
react-platform-adapter-previewand set it asprivate: false. Because this change is happening in thexplatbranch and notmaster, this will not result in the package being published for now. However, it is necessary to mark as public so the CI builds don't fail.