chore(nx): enable analyzeSourceFiles in order to build dependency gra…

…ph based on source files instead statically defined package.json dependencies (#32359)

.nxignore

@@ -9,4 +9,19 @@ packages/fluentui/CONTRIBUTING.md
 packages/fluentui/README.md
 packages/fluentui/.browserslistrc
 
+
+; build output
 **/dist/**
+
+; known directories to not incorporate into the workspace graph creation
+**/fixtures/**
+**/__fixtures__/**
+**/bundle-size/**
+
+; scaffolding templates
+**/generators/**/files/**
+plop-templates
+plop-templates-*
+
+; TODO: temporary ignore - remove once https://github.com/microsoft/fluentui/pull/32371 is merged
+scripts/*/just.config.ts

change/@fluentui-babel-preset-global-context-7315ea8d-11d8-4f60-8609-1607fad9033e.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/babel-preset-global-context",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-eslint-plugin-bfd756b0-f796-4aae-a6e0-5b55d89dba44.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: resolve circular dependencies and remove ban-context-export tests tight coupling to monorepo setup/package",
+  "packageName": "@fluentui/eslint-plugin",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-aria-1618f661-53d5-4a10-b243-2e86afa6b257.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-aria",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-conformance-4282f4cc-cb8b-4817-930e-afe56e143bf3.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: reflect package.json dependencies to match actual dep graph",
+  "packageName": "@fluentui/react-conformance",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-datepicker-compat-28a5f8d4-19a1-4724-b89b-fc87036b9424.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-datepicker-compat",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-infolabel-ee3a8fd8-9522-4f84-b345-c9a0292730cd.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-infolabel",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-list-preview-3e3b4786-e7ca-47f6-9876-0a9e7f8e7416.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-list-preview",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-migration-v8-v9-61b66157-b0c6-48a4-9087-c32eff308bae.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix: cleanup production dependencies and fix forbidden sub-package import within Menu",
+  "packageName": "@fluentui/react-migration-v8-v9",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-table-8a5112c5-b6a7-4b60-94ea-cca71d8f054d.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-table",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-tag-picker-19a4c535-9d2f-4bf4-bdf8-646f51cd0930.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-tag-picker",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-timepicker-compat-952aa2df-f90e-4cae-a0b5-341d5b4af632.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-timepicker-compat",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-toast-f54ca38d-fce3-425f-8c36-7453496e6cdb.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: add missing workspace scripts-cypress devDependencies",
+  "packageName": "@fluentui/react-toast",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-utilities-424ef027-dedc-45ae-97b0-9eff344bd020.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: reflect package.json dependencies to match actual dep graph",
+  "packageName": "@fluentui/react-utilities",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

nx.json

@@ -4,11 +4,6 @@
     "libsDir": "packages",
     "appsDir": "apps"
   },
-  "pluginsConfig": {
-    "@nx/js": {
-      "analyzeSourceFiles": false
-    }
-  },
   "targetDefaults": {
     "bundle-size": {
       "dependsOn": ["build"],

packages/eslint-plugin/.eslintrc.json

@@ -9,6 +9,12 @@
         // too many false positives on node types
         "@typescript-eslint/naming-convention": "off"
       }
+    },
+    {
+      "files": ["src/rules/**/fixtures/**/*.{js,ts}"],
+      "rules": {
+        "import/no-extraneous-dependencies": "off"
+      }
     }
   ]
 }

packages/eslint-plugin/src/configs/react.js

@@ -30,6 +30,7 @@ module.exports = {
     '@fluentui/no-context-default-value': [
       'error',
       {
+        // nx-ignore-next-line - this is a valid use case to ignore workspace packages. keeping  them part of the project dependencies would be wrong assumption
         imports: ['react', '@fluentui/react-context-selector', '@fluentui/global-context'],
       },
     ],

packages/eslint-plugin/src/rules/ban-context-export/fixtures/context-selector/src/context.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { createContext } from '@fluentui/react-context-selector';
+import { createContext } from '@proj/react-context-selector';
 
 export const MyContext = createContext({});

packages/eslint-plugin/src/rules/ban-context-export/fixtures/context-selector/tsconfig.json

@@ -6,6 +6,10 @@
     "outDir": "dist",
     "declaration": true,
     "declarationDir": "dist/types",
-    "types": ["static-assets", "environment"]
+    "types": ["static-assets", "environment"],
+    "baseUrl": ".",
+    "paths": {
+      "@proj/react-context-selector": ["../react-context-selector-pkg/index.ts"]
+    }
   }
 }

packages/eslint-plugin/src/rules/ban-context-export/fixtures/export-specifier/src/context.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
 import * as React from 'react';
 
 export const MyContext = React.createContext({});

packages/eslint-plugin/src/rules/ban-context-export/fixtures/internal-export/src/internal/context.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
 import * as React from 'react';
 
 export const MyContext = React.createContext({});

packages/eslint-plugin/src/rules/ban-context-export/fixtures/named-export/tsconfig.json

@@ -6,6 +6,10 @@
     "outDir": "dist",
     "declaration": true,
     "declarationDir": "dist/types",
-    "types": ["static-assets", "environment"]
+    "types": ["static-assets", "environment"],
+    "baseUrl": ".",
+    "paths": {
+      "@proj/react-context-selector": ["../react-context-selector-pkg/index.ts"]
+    }
   }
 }

packages/eslint-plugin/src/rules/ban-context-export/fixtures/react-context-selector-pkg/context.ts

@@ -0,0 +1,5 @@
+import type { Context } from './types';
+
+export const createContext = <T>(value: T): Context<T> => {
+  return {} as Context<T>;
+};

packages/eslint-plugin/src/rules/ban-context-export/fixtures/react-context-selector-pkg/index.ts

@@ -0,0 +1 @@
+export { createContext } from './context';

packages/eslint-plugin/src/rules/ban-context-export/fixtures/react-context-selector-pkg/types.ts

@@ -0,0 +1,6 @@
+import * as React from 'react';
+
+export type Context<Value> = React.Context<Value> & {
+  Provider: React.FC<React.ProviderProps<Value>>;
+  Consumer: never;
+};

packages/eslint-plugin/src/rules/ban-context-export/index.test.js

@@ -77,7 +77,7 @@ ruleTester.run('ban-context-export', rule, {
       errors: [{ messageId: 'contextSelector' }],
       parserOptions: getParserOptions('named-export'),
       code: `
-      import { createContext } from '@fluentui/react-context-selector';
+      import { createContext } from '@proj/react-context-selector';
       export const MyContext = createContext({});
       `,
       filename: 'src/index.ts',

packages/eslint-plugin/src/rules/no-context-default-value/index.test.js

@@ -10,52 +10,52 @@ ruleTester.run('no-context-default-value', rule, {
     {
       code: `
         import {createContext as createContext1} from 'react'
-        import {createContext as createContext2} from '@fluentui/react-context-selector'
+        import {createContext as createContext2} from '@proj/react-context-selector'
         const context1 = createContext1();
         const context2 = createContext2();
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
     },
     {
       code: `
         import {createContext as createContext1} from 'react'
-        import {createContext as createContext2} from '@fluentui/react-context-selector'
+        import {createContext as createContext2} from '@proj/react-context-selector'
         const context1 = createContext1(undefined);
         const context2 = createContext2(undefined);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
     },
     {
       code: `
         import * as React from 'react'
-        import * as ContextSelector from '@fluentui/react-context-selector'
+        import * as ContextSelector from '@proj/react-context-selector'
         const context1 = React.createContext(undefined);
         const context2 = ContextSelector.createContext(undefined);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
     },
     {
       code: `
         import React from 'react'
-        import ContextSelector from '@fluentui/react-context-selector'
+        import ContextSelector from '@proj/react-context-selector'
         const context1 = React.createContext(undefined);
         const context2 = ContextSelector.createContext(undefined);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
     },
@@ -64,69 +64,69 @@ ruleTester.run('no-context-default-value', rule, {
     {
       code: `
         import {createContext as createContext1} from 'react'
-        import {createContext as createContext2} from '@fluentui/react-context-selector'
+        import {createContext as createContext2} from '@proj/react-context-selector'
         const context1 = createContext1(null);
         const context2 = createContext2(null);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
       errors: [{ messageId: 'invalidDefaultValue' }, { messageId: 'invalidDefaultValue' }],
     },
     {
       code: `
         import {createContext as createContext1} from 'react'
-        import {createContext as createContext2} from '@fluentui/react-context-selector'
+        import {createContext as createContext2} from '@proj/react-context-selector'
         const context1 = createContext1({});
         const context2 = createContext2({});
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
       errors: [{ messageId: 'invalidDefaultValue' }, { messageId: 'invalidDefaultValue' }],
     },
     {
       code: `
         import {createContext as createContext1} from 'react'
-        import {createContext as createContext2} from '@fluentui/react-context-selector'
+        import {createContext as createContext2} from '@proj/react-context-selector'
         const context1 = createContext1(defaultValue);
         const context2 = createContext2(defaultValue);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
       errors: [{ messageId: 'invalidDefaultValue' }, { messageId: 'invalidDefaultValue' }],
     },
     {
       code: `
         import * as React from 'react'
-        import * as ContextSelector from '@fluentui/react-context-selector'
+        import * as ContextSelector from '@proj/react-context-selector'
         const context1 = React.createContext(defaultValue);
         const context2 = ContextSelector.createContext(defaultValue);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
       errors: [{ messageId: 'invalidDefaultValue' }, { messageId: 'invalidDefaultValue' }],
     },
     {
       code: `
         import React from 'react'
-        import ContextSelector from '@fluentui/react-context-selector'
+        import ContextSelector from '@proj/react-context-selector'
         const context1 = React.createContext(defaultValue);
         const context2 = ContextSelector.createContext(defaultValue);
       `,
       options: [
         {
-          imports: ['react', '@fluentui/react-context-selector'],
+          imports: ['react', '@proj/react-context-selector'],
         },
       ],
       errors: [{ messageId: 'invalidDefaultValue' }, { messageId: 'invalidDefaultValue' }],

packages/fluentui/accessibility/test/behaviors/behavior-test.tsx

@@ -107,6 +107,8 @@ import {
 import { TestHelper } from './testHelper';
 import { definitions } from './testDefinitions';
 
+// @{link 'file://./../../../docs/src/behaviorMenu.json'}
+// nx-ignore-next-line - following pragma ignores 'docs' project(application) being part of this package dependencies from nx - 🚨 NOTE: this is wrong as without docs project json files generated this test wont work.
 const behaviorMenuItems = require('../../../docs/src/behaviorMenu');
 
 const testHelper = new TestHelper();

packages/fluentui/perf-test-northstar/.digest/config.tsx

@@ -3,6 +3,7 @@ import { Provider, teamsTheme } from '@fluentui/react-northstar';
 
 const reqContexts = [
   // TODO: Relative pathing isn't the best here, but docs containing perf stories isn't a package that can be added as a dep.
+  // nx-ignore-next-line - ignoring from nx dep graph because this is resolved via storybook behind the scenes without no build assets needed.
   require.context('../../docs/src', true, /\.perf\.tsx$/),
   // TODO: why does this break index.html?? seems to pull in stories the same way...
   // require.context('../stories', true, /\.perf\.tsx$/),

packages/react-components/babel-preset-global-context/package.json

@@ -13,7 +13,6 @@
     "build": "just-scripts build --module cjs",
     "clean": "just-scripts clean",
     "code-style": "just-scripts code-style",
-    "pree2e": "yarn build",
     "e2e": "cypress run --component",
     "e2e:local": "cypress open --component",
     "just": "just-scripts",

packages/react-components/react-aria/library/package.json

@@ -29,7 +29,8 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/react-conformance": "*",
     "@fluentui/scripts-api-extractor": "*",
-    "@fluentui/scripts-tasks": "*"
+    "@fluentui/scripts-tasks": "*",
+    "@fluentui/scripts-cypress": "*"
   },
   "dependencies": {
     "@fluentui/keyboard-keys": "^9.0.7",