Skip to content

Fix: Correct total row logic and improve table rendering in code1.py #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mukundjha-mj
Copy link

@mukundjha-mj mukundjha-mj commented May 11, 2025

Summary of Changes:

  • Corrected the total row logic to ensure accurate calculations for quantities and totals in the table.
  • Improved table rendering for better clarity and user experience by ensuring consistent data representation.

@mukundjha-mj mukundjha-mj force-pushed the add-fix-table-code1 branch from 04308b4 to 82b1c6c Compare May 11, 2025 05:16
@mukundjha-mj mukundjha-mj changed the title Fix: Add total row and improve table formatting in code1.py Fix: Correct total row logic and improve table rendering in code1.py May 11, 2025
@mukundjha-mj
Copy link
Author

Hi @AtishayMsft

It's been a week since I opened this PR. Just wanted to kindly follow up and see if there's anything I should improve or change.

This is my first contribution to this repository, and I’d really appreciate your feedback or review when you have time. Thank you!

import json
import plotly.graph_objects as go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this PR

@@ -23,4 +23,4 @@
f.write(fig_json)

# Optional: print preview of JSON (first 300 characters)
print(fig_json[:300])
print("Preview of exported JSON:\n", fig_json[:300], "...")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you post the screenshot of new output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants