Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable stringification of DOM nodes controlled by FAST's renderer #6823

Open
wants to merge 3 commits into
base: archives/fast-element-1
Choose a base branch
from
Open

feat: enable stringification of DOM nodes controlled by FAST's renderer #6823

wants to merge 3 commits into from

Conversation

nicholasrice
Copy link
Contributor

Pull Request

📖 Description

Enable JSON.stringy() for fast-controlled DOM nodes. This PR implements #6485 for fast v1.

🎫 Issues

fixes #6812

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@nicholasrice nicholasrice changed the base branch from master to archives/fast-element-1 August 23, 2023 17:57
@janechu
Copy link
Collaborator

janechu commented Sep 11, 2024

Looks like we need to add a change file, can you run yarn change to generate one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janechu janechu janechu approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@awentzel awentzel awentzel approved these changes

@KingOfTac KingOfTac KingOfTac approved these changes

@EisenbergEffect EisenbergEffect Awaiting requested review from EisenbergEffect

@bheston bheston Awaiting requested review from bheston

@Falkicon Falkicon Awaiting requested review from Falkicon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: fast-element v1 controlled DOM nodes cannot be JSON serialized
5 participants
@nicholasrice @janechu @chrisdholt @awentzel @KingOfTac