chore: remove 'applyMixins' function #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
commented
Jul 6, 2023
change/@microsoft-fast-foundation-b1cdc933-e7be-42e8-8d85-95a5af001f1a.json
Outdated
Show resolved
Hide resolved
nicholasrice
commented
Jul 6, 2023
change/@microsoft-fast-foundation-b1cdc933-e7be-42e8-8d85-95a5af001f1a.json
Outdated
Show resolved
Hide resolved
nicholasrice
force-pushed
the
users/nirice/remove-apply-mixins-export
branch
from
4f7ff97
to
749442d
Compare
KingOfTac
approved these changes
Jul 7, 2023
chrisdholt
approved these changes
Jul 17, 2023
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* remove apply mixins from exported features * Change files * Update change/@microsoft-fast-foundation-b1cdc933-e7be-42e8-8d85-95a5af001f1a.json --------- Co-authored-by: nicholasrice <[email protected]> Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR removes the 'applyMixins' function from exported features. 'applyMixins' is an implementation detail of fast-foundation components and doesn't relate to the package's purpose. Additionally, there are better mixin patterns that don't rely on copying property descriptors manually, such as defining mixin classes as functions accepting a base class.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps