Downgrade required grpcio and protobuf versions
#36
+414
−661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berndverst
commented
Jan 8, 2025
|
This fixes #8 |
elena-kolevska
pushed a commit
to elena-kolevska/durabletask-python
that referenced
this pull request
Jan 9, 2025
elena-kolevska
pushed a commit
to elena-kolevska/durabletask-python
that referenced
this pull request
Jan 9, 2025
Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This downgrades the required
grpcioversion by pinninggrpcio-toolsas dev-only requirement to version 1.62.3 which is the last release before a breaking change in protobuf is introduced (with 1.26.X / 3.26.X).The protos are recompiled with this version. (Note: protos compiled with grpcio-tools 1.67.0 for example MUST be loaded with grpcio 1.67.0 or higher hence recompilation with an older version was necessary)
Additional improvements:
The proto generation has been changed to no longer require manual edits.