Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rewind client API #123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add rewind client API #123

wants to merge 4 commits into from

Conversation

shreyas-gopalakrishna
Copy link
Member

Issue describing the changes in this PR

resolves #65

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

shreyas-gopalakrishna
shreyas-gopalakrishna commented Mar 10, 2023
View reviewed changes
samples-azure-functions/extensions.csproj Outdated
<DefaultItemExcludes>**</DefaultItemExcludes>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.9.2" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this config is currently resulting in the below exception. Should we wait for next bundle release?
MicrosoftTeams-image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmrdavid how close are we to completing the v2.9.3 extension release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the v2.9.3 extension release is in the validation stage right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyas-gopalakrishna , Can we try again without this .csproj file, the v2.9.3 should be included in the extension bundle by now. Thanks.

@shreyas-gopalakrishna shreyas-gopalakrishna marked this pull request as ready for review March 10, 2023 19:16
cgillum
cgillum requested changes Mar 10, 2023
View reviewed changes
samples-azure-functions/extensions.csproj Outdated
<DefaultItemExcludes>**</DefaultItemExcludes>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.9.2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmrdavid how close are we to completing the v2.9.3 extension release?

samples-azure-functions/src/main/java/com/functions/RewindInstance.java Outdated Show resolved Hide resolved
samples-azure-functions/src/main/java/com/functions/RewindInstance.java Outdated Show resolved Hide resolved
samples-azure-functions/src/main/java/com/functions/RewindInstance.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/main/java/com/functions/RewindInstance.java Show resolved Hide resolved
cgillum
cgillum requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comments.

Moving forward, please be especially mindful about variable naming. Poor variable names can make it a lot harder to correctly understand and review code. It can also be a distraction. Good variable naming, on the other hand, can make everything much easier to understand quickly and makes the overall code feel more professional and polished.

samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java Outdated Show resolved Hide resolved
cgillum
cgillum previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks!

shreyas-gopalakrishna
shreyas-gopalakrishna commented Oct 25, 2023
View reviewed changes
Copy link
Member Author

@shreyas-gopalakrishna shreyas-gopalakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Facing the above proto issue when running rewind instance on ExtensionVersion: 2.10.0
cc @cgillum @kaibocai if this has been encontered before

@kaibocai kaibocai mentioned this pull request Nov 1, 2023
Open
@herry2525 herry2525 mentioned this pull request Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum left review comments

@kaibocai kaibocai Awaiting requested review from kaibocai kaibocai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rewind client API
3 participants
@shreyas-gopalakrishna @cgillum @kaibocai