Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GetInstance method to handle instance not found error gracefully #87

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Dec 28, 2024

Fixes irritating behavior where a gRPC error is returned by client operations to fetch orchestration state when the orchestration doesn’t exist. Instead, we should return a proper response indicating that the orchestration doesn’t exist.

@cgillum cgillum merged commit 898b51a into microsoft:main Dec 28, 2024
4 checks passed
@cgillum cgillum deleted the cgillum/instance-not-found branch December 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant