Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demikernel] Enhancement: prepare for publishing to crates.io #1503

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[demikernel] Enhancement: prepare for publishing to crates.io #1503

merged 3 commits into from
Feb 12, 2025

Conversation

anandbonde
Copy link
Contributor

Preparing crates for publishing to crates.io. Refer to commit tab for detailed changes.

After this PR is merged into the dev branch, we will:

  1. Bring the unstable branch up to date with dev using rebase.
  2. Add tags to the unstable branch with crates.io version tags, so as to be able to reproduce the code corresponding to those versions.

@anandbonde anandbonde requested a review from iyzhang February 11, 2025 19:38
@anandbonde anandbonde self-assigned this Feb 11, 2025
@github-actions GitHub Actions
Copy link

libos = catnap
commit id = f4547d5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 13720681 3674 1521 6918227937 100 6918227937 100
ioc::network::libos::push 17600 481 236 7535350 0 7535350 0
ioc::network::libos::pop 15351 454 219 5570981 0 5570981 0
ioc::network::libos::connect 50 158906 66072 2817604 0 2817604 0
demikernel::sgaalloc 11290 148 60 1214992 0 1214992 0
demikernel::sgafree 11539 78 36 886182 0 886182 0
ioc::network::libos::pushto 1461 358 142 530789 0 530789 0
ioc::network::libos::accept 26 13036 6263 404983 0 404983 0
ioc::network::libos::close 18 23599 10828 334377 0 334377 0

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = f4547d5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 29030074 204 100 5870784845 20 5870784845 46
bgc::inetstack::poll;inetstack::layer4::poll_once 29030074 358 175 9979971300 35 4104715912 32
bgc::inetstack::poll 14515037 914 447 12808414103 45 2828442803 22
ioc::network::libos::push 16145 1191 490 17388309 0 15263516 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11058 344 165 4638244 0 4637173 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2463 2225 1119 4546314 0 4528495 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11070 329 178 3025387 0 3022161 0
bgc::inetstack::tcp::established::background 11070 1121 583 11198033 0 2830117 0
ioc::network::libos::pop 9045 434 244 2711451 0 2711451 0
ioc::network::libos::push;catnip::runtime::transmit 8763 336 139 2306919 0 2306919 0
ioc::network::libos::pushto 1313 1380 580 1814649 0 1454359 0
ioc::network::libos::connect 42 36324 15125 1439997 0 1385019 0
demikernel::sgaalloc 6540 143 59 732347 0 732347 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11015 314 175 704285 0 694158 0
demikernel::sgafree 8784 94 47 692555 0 692555 0
ioc::network::libos::pushto;catnip::runtime::transmit 1313 274 115 360290 0 360290 0
bgc::inetstack::tcp::passiveopen::background 42 34267 14991 403462 0 348408 0
ioc::network::libos::close 49 5987 2480 282394 0 282394 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 559 253 106 136803 0 136803 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 16485 6880 55054 0 55054 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6252 2535 54978 0 54978 0
ioc::network::libos::accept 38 2115 1025 44899 0 44899 0
bgc::inetstack::arp::background 7 2497 1276 21929 0 21929 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 17 1398 599 16423 0 16423 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 24 559 269 11445 0 11445 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 528 247 10127 0 10127 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 10 1259 540 5993 0 5993 0
bgc::inetstack::icmp::background 1 2380 1241 2555 0 2555 0

@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = f4547d5

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 21291972 652 263 12345896689 46 12337505808 84
bgc::inetstack::poll 10645986 1510 608 14542343481 54 2196446792 15
ioc::network::libos::push 16145 2954 1214 48949748 0 48949748 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5876 2616 1037 8533100 0 8531206 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11631 443 177 5625977 0 5625977 0
ioc::network::libos::pushto 1207 4261 1882 5061341 0 5061341 0
ioc::network::libos::pop 9247 446 180 3505673 0 3505673 0
bgc::inetstack::tcp::established::background 11645 1861 734 13281406 0 3356196 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11645 636 250 3324617 0 3324617 0
ioc::network::libos::connect 42 41487 16770 1642266 0 1642266 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11588 981 378 974616 0 974616 0
demikernel::sgaalloc 6569 145 59 947140 0 947140 0
demikernel::sgafree 8778 123 50 648062 0 648062 0
bgc::inetstack::tcp::passiveopen::background 42 20186 8163 517519 0 517519 0
ioc::network::libos::close 46 6801 2727 299159 0 299159 0
ioc::network::libos::accept 39 2321 930 53140 0 53140 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 193 204 91 37242 0 37242 0
bgc::inetstack::arp::background 7 2227 894 13612 0 13612 0
bgc::inetstack::icmp::background 1 2358 949 2622 0 2622 0

@anandbonde anandbonde changed the title [demikernel] prepare crates for publishing to crates.io [demikernel] Enhancement: prepare crates for publishing to crates.io Feb 11, 2025
@anandbonde anandbonde changed the title [demikernel] Enhancement: prepare crates for publishing to crates.io [demikernel] Enhancement: prepare for publishing to crates.io Feb 11, 2025
@anandbonde
[dpdk-bindings] Bug Fix: remove -std=c11 flag for Linux
f759ffb 
On Linux, the "cargo publish" step was showing build errors when the
-std=c11 flag is used. So, reverting it now and we will bring it back on
need basis when we upgrade the DPDK version to v23.11 and beyond.
@anandbonde
[crates] Enhancement: add consistent license metadata
4310093 
The license metadata in the Cargo.toml files for crates was
inconsistent. To avoid conflicts, changing them to match for uniformity
across all crates.
@anandbonde
[dpdk-bindings] Enhancement: updated doc with clang usage steps
322d346 
Currently, we use Clang to build DPDK bindings for rust, so adding steps
to the readme for the same.
@anandbonde anandbonde force-pushed the ab-prepare-for-crates.io branch from f4547d5 to 322d346 Compare February 12, 2025 17:47
@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = 322d346

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 21907271 631 250 12613496520 46 12604829953 85
bgc::inetstack::poll 10953636 1467 583 14823927168 54 2210430648 15
ioc::network::libos::push 16145 2926 1175 46689573 0 46689573 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5920 2878 1128 8813457 0 8811659 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11659 440 174 5756413 0 5756413 0
bgc::inetstack::tcp::established::background 11676 1846 720 13263893 0 3356867 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11676 719 278 3230403 0 3230403 0
ioc::network::libos::pop 9246 443 176 3227554 0 3227554 0
ioc::network::libos::pushto 630 4523 1976 2823717 0 2823717 0
ioc::network::libos::connect 42 39540 15870 1632360 0 1632360 0
demikernel::sgaalloc 6498 142 57 995425 0 995425 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11616 837 323 920211 0 920211 0
demikernel::sgafree 8746 103 41 657995 0 657995 0
bgc::inetstack::tcp::passiveopen::background 42 16706 6486 423429 0 423429 0
ioc::network::libos::close 46 6426 2550 289812 0 289812 0
ioc::network::libos::accept 39 2320 901 52720 0 52720 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 187 209 91 35359 0 35359 0
bgc::inetstack::arp::background 7 2706 1071 13925 0 13925 0
bgc::inetstack::icmp::background 1 6136 2382 6530 0 6530 0

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = 322d346

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 13561747 3347 1402 6887296852 100 6887296852 100
ioc::network::libos::push 17600 507 212 7744476 0 7744476 0
ioc::network::libos::pop 15423 486 209 5686154 0 5686154 0
ioc::network::libos::connect 50 149009 62907 2741798 0 2741798 0
demikernel::sgaalloc 11280 128 54 1128012 0 1128012 0
demikernel::sgafree 11534 81 35 864326 0 864326 0
ioc::network::libos::accept 25 13276 5627 403647 0 403647 0
ioc::network::libos::pushto 1033 344 147 343513 0 343513 0
ioc::network::libos::close 18 23281 9941 324635 0 324635 0

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = 322d346

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 29125601 205 83 5950382381 20 5950382381 46
bgc::inetstack::poll;inetstack::layer4::poll_once 29125601 364 148 10105372443 35 4150249484 32
bgc::inetstack::poll 14562801 924 375 12923495823 45 2818123380 22
ioc::network::libos::push 16145 1190 490 17633876 0 15490988 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2883 3447 1354 4820928 0 4801483 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11058 349 142 4585441 0 4584482 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11071 307 124 2891789 0 2888975 0
bgc::inetstack::tcp::established::background 11071 1096 440 10985163 0 2806273 0
ioc::network::libos::pop 9046 414 167 2664671 0 2664671 0
ioc::network::libos::push;catnip::runtime::transmit 8763 334 137 2326565 0 2326565 0
ioc::network::libos::pushto 1346 1431 616 1921159 0 1534268 0
ioc::network::libos::connect 42 34597 14173 1415380 0 1358065 0
demikernel::sgaalloc 6542 145 59 714944 0 714944 0
demikernel::sgafree 8786 91 37 696551 0 696551 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11016 319 124 701661 0 690479 0
ioc::network::libos::pushto;catnip::runtime::transmit 1346 291 125 386891 0 386891 0
bgc::inetstack::tcp::passiveopen::background 42 35606 14506 393811 0 339219 0
ioc::network::libos::close 49 5657 2302 260245 0 260245 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 574 290 124 152740 0 152740 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6416 2627 57316 0 57316 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 18844 7691 54592 0 54592 0
ioc::network::libos::accept 37 2279 926 47623 0 47623 0
bgc::inetstack::arp::background 7 2464 999 21164 0 21164 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 18 953 389 13129 0 13129 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 24 628 253 12304 0 12304 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 565 229 11182 0 11182 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 11 1753 708 5368 0 5368 0
bgc::inetstack::icmp::background 1 2427 985 2585 0 2585 0

@anandbonde anandbonde merged commit 31c924b into dev Feb 12, 2025
14 checks passed
@anandbonde anandbonde deleted the ab-prepare-for-crates.io branch February 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandbonde @iyzhang