Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix escape character warnings #1484

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[ci] Fix escape character warnings #1484

merged 1 commit into from
Jan 14, 2025

Conversation

anandbonde
Copy link
Contributor

Recent updates on GitHub side has resulted in warnings in Python code related to escape sequences. This PR addresses those warnings.

@anandbonde anandbonde requested a review from iyzhang January 13, 2025 19:37
@anandbonde anandbonde self-assigned this Jan 13, 2025
@anandbonde anandbonde force-pushed the ab-fix-escape-char-warnings branch from a89f73d to 926e3fe Compare January 13, 2025 19:41
@anandbonde anandbonde force-pushed the ab-fix-escape-char-warnings branch from 926e3fe to 71141e4 Compare January 13, 2025 19:43
@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = 71141e4

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 19713386 697 285 11923097869 46 11917586585 85
bgc::inetstack::poll 9856693 1600 654 13854956006 53 1931858138 14
demikernel::new 1 97727936 39652007 97727936 0 97727936 1
ioc::network::libos::push 16145 3042 1276 47551171 0 47551171 0
ioc::network::libos::pushto 4365 4168 1718 17621767 0 17621767 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11049 421 172 5868377 0 5868377 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5350 2306 912 5604696 0 5589966 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11060 544 227 3826669 0 3826669 0
ioc::network::libos::pop 9106 568 243 3495859 0 3495859 0
bgc::inetstack::tcp::established::background 11060 1750 710 14022082 0 3433505 0
ioc::network::libos::connect 42 43244 18118 1587539 0 1587539 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11007 887 343 893531 0 893531 0
demikernel::sgaalloc 6807 153 65 863218 0 863218 0
demikernel::sgafree 8957 124 50 829659 0 829659 0
bgc::inetstack::tcp::passiveopen::background 42 33543 13876 495754 0 495754 0
ioc::network::libos::close 47 7013 2890 305645 0 305645 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 1481 204 83 289691 0 289691 0
ioc::network::libos::accept 39 2059 846 49187 0 49187 0
demikernel::bind 1 25610 10098 25610 0 25610 0
bgc::inetstack::arp::background 6 2174 882 12672 0 12672 0
demikernel::socket 10 1934 784 7877 0 7877 0
demikernel::listen 1 3786 1518 3786 0 3786 0
bgc::inetstack::icmp::background 1 3273 1338 3408 0 3408 0

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = 71141e4

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 13358480 2116 883 7204823505 100 7204823505 100
ioc::network::libos::push 17600 473 195 8122687 0 8122687 0
ioc::network::libos::pop 12190 515 213 5036305 0 5036305 0
ioc::network::libos::connect 50 52561 21836 2094338 0 2094338 0
demikernel::sgaalloc 11279 153 65 1935212 0 1935212 0
demikernel::sgafree 11533 80 33 944313 0 944313 0
demikernel::socket 10 154383 62483 544803 0 544803 0
ioc::network::libos::accept 27 20754 8659 539435 0 539435 0
ioc::network::libos::close 18 23787 9830 366075 0 366075 0
ioc::network::libos::pushto 984 403 164 354071 0 354071 0
demikernel::new 1 266043 110484 266043 0 266043 0
demikernel::bind 1 29411 12144 29411 0 29411 0
demikernel::listen 1 15267 6303 15267 0 15267 0

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = 71141e4

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 29167339 202 81 5847105274 19 5847105274 40
bgc::inetstack::poll;inetstack::layer4::poll_once 29167339 357 143 10014897157 33 4163135347 28
bgc::inetstack::poll 14583670 921 369 12870866890 42 2855969733 19
demikernel::new 1 1762709820 703750807 1762709820 6 1762709820 12
ioc::network::libos::push 16145 1120 455 16858775 0 14662279 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11361 354 142 4879457 0 4878793 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 4698 1832 720 4735460 0 4622661 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11372 307 122 3091652 0 3089449 0
bgc::inetstack::tcp::established::background 11372 1097 437 11624555 0 2940034 0
ioc::network::libos::pop 9210 365 146 2740821 0 2740821 0
ioc::network::libos::push;catnip::runtime::transmit 8763 320 131 2384766 0 2384766 0
ioc::network::libos::pushto 1232 1301 555 1603797 0 1277815 0
ioc::network::libos::connect 42 31408 12745 1157103 0 1099143 0
demikernel::sgafree 8780 93 37 710366 0 710366 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11318 303 117 713413 0 702842 0
demikernel::sgaalloc 6535 134 55 629849 0 629849 0
bgc::inetstack::tcp::passiveopen::background 42 35504 14180 388637 0 332071 0
ioc::network::libos::pushto;catnip::runtime::transmit 1232 265 113 325981 0 325981 0
ioc::network::libos::close 49 5864 2350 271309 0 271309 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 541 263 107 151781 0 151781 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 329 680 272 110710 0 110710 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6213 2461 57960 0 57960 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 18892 7555 56566 0 56566 0
ioc::network::libos::accept 38 2049 818 47013 0 47013 0
bgc::inetstack::arp::background 7 2359 943 19931 0 19931 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 13 1666 664 12335 0 12335 0
demikernel::bind 1 11713 4639 11713 0 11713 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 579 230 10570 0 10570 0
demikernel::socket 10 2127 848 7573 0 7573 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 12 1108 455 4648 0 4648 0
demikernel::listen 1 3548 1453 3548 0 3548 0
bgc::inetstack::icmp::background 1 2976 1189 3182 0 3182 0

@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = 71141e4

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 19973638 685 278 12136816872 46 12131349590 85
bgc::inetstack::poll 9986819 1576 640 14092540429 53 1955723557 14
demikernel::new 1 99423364 40309584 99423364 0 99423364 1
ioc::network::libos::push 16145 3399 1413 48182670 0 48182670 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11057 483 197 5748185 0 5748185 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5293 2642 1044 5559948 0 5557270 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11069 575 231 3711726 0 3711726 0
bgc::inetstack::tcp::established::background 11069 1866 747 13665619 0 3333653 0
ioc::network::libos::pushto 766 4317 1855 3303185 0 3303185 0
ioc::network::libos::pop 9034 434 176 3270949 0 3270949 0
ioc::network::libos::connect 42 48503 20241 1684846 0 1684846 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11014 931 361 872055 0 872055 0
demikernel::sgaalloc 6507 178 74 832836 0 832836 0
demikernel::sgafree 8753 131 53 812589 0 812589 0
bgc::inetstack::tcp::passiveopen::background 42 33189 13215 438250 0 438250 0
ioc::network::libos::close 47 6988 2863 326525 0 326525 0
ioc::network::libos::accept 38 3185 1248 93046 0 93046 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 264 208 88 52666 0 52666 0
demikernel::bind 1 25373 9973 25373 0 25373 0
bgc::inetstack::arp::background 7 2310 930 13208 0 13208 0
demikernel::socket 10 2286 918 8280 0 8280 0
bgc::inetstack::icmp::background 1 3514 1421 3645 0 3645 0
demikernel::listen 1 3300 1306 3300 0 3300 0

iyzhang
iyzhang approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = 71141e4

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 13469171 2005 850 7235062319 100 7235062319 100
ioc::network::libos::push 17600 452 204 7659292 0 7659292 0
ioc::network::libos::pop 12533 505 220 4894351 0 4894351 0
ioc::network::libos::connect 50 50351 21328 2029843 0 2029843 0
ioc::network::libos::pushto 4816 325 138 1566381 0 1566381 0
demikernel::sgaalloc 11376 134 57 1515947 0 1515947 0
demikernel::sgafree 11582 79 34 912202 0 912202 0
demikernel::socket 10 149992 63597 526330 0 526330 0
ioc::network::libos::accept 27 17424 7343 510996 0 510996 0
ioc::network::libos::close 18 23379 10079 341388 0 341388 0
demikernel::new 1 263959 114936 263959 0 263959 0
demikernel::bind 1 27995 13257 27995 0 27995 0
demikernel::listen 1 14672 6506 14672 0 14672 0

@anandbonde anandbonde merged commit 0647582 into dev Jan 14, 2025
14 checks passed
@anandbonde anandbonde deleted the ab-fix-escape-char-warnings branch January 14, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandbonde @iyzhang