Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inetstack] Enhancement: Hardcode for Windows #1479

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Dec 13, 2024

This closes #1391. Windows requires a specific dummy MAC on Azure, but Linux does not, so this should work for both.

@iyzhang iyzhang requested a review from anandbonde December 13, 2024 17:42
@iyzhang iyzhang self-assigned this Dec 13, 2024
Copy link

libos = catpowder
commit id = d29bdf7

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once 19342471.83 683.01 274.60 84.91
bgc::inetstack::poll 9671235.92 1615.14 649.68 56.90
bgc::inetstack::tcp::established::background 11528.84 1725.57 682.92 0.18
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11528.84 499.83 197.22 23.56
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11518.39 409.10 164.80 28.72
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11476.04 931.54 359.47 22.97
ioc::network::libos::pop 9191.45 421.78 168.35 0.04
ioc::network::libos::push;inetstack::push 8762.80 6373.29 2618.02 2.32
demikernel::sgafree 8745.79 120.62 48.71 0.01
ioc::network::libos::push 8073.74 33583358.66 14463875.58 38.50
demikernel::push 8073.74 640.46 261.31 0.05
demikernel::sgaalloc 6498.12 166.90 68.08 0.02
demikernel::pop 6034.41 655.56 260.11 0.04
bgc::inetstack::poll;inetstack::poll_bg_work::for::for 5731.66 2369.58 928.42 1.16
ioc::network::libos::pushto 630.33 4536.58 1818.42 2.37
ioc::network::libos::pushto;inetstack::push 630.33 4095.04 1641.76 90.27
demikernel::pushto 630.33 508.98 204.03 0.26
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;udp::receive 185.33 191.36 75.57 60.08
ioc::network::libos::close 47.15 6014.65 2416.33 0.08
ioc::network::libos::connect 41.86 38732.04 15819.60 0.45
bgc::inetstack::tcp::passiveopen::background 41.86 32311.09 12875.13 0.01
ioc::network::libos::accept 38.25 2867.91 1165.81 0.00
demikernel::async_close 32.50 732.24 281.28 0.01
demikernel::accept 21.86 1709.15 673.65 0.00
demikernel::connect 20.93 4213.14 1693.88 0.03
demikernel::socket 10.30 2783.35 1120.64 0.00
bgc::inetstack::arp::background 6.58 2181.86 872.78 0.00
bgc::inetstack::icmp::background 1.03 3243.20 1297.15 0.00
demikernel::new 1.00 95239834.95 37944130.68 17.99
demikernel::bind 1.00 25528.94 9974.09 0.00
demikernel::listen 1.00 5364.36 2179.39 0.00
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnap
commit id = d29bdf7

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13387015.99 1879.94 1022.81 32.45
demikernel::sgafree 11534.56 72.03 32.05 0.05
demikernel::sgaalloc 11281.02 126.95 59.84 0.10
ioc::network::libos::push;catnap::linux::transport::push 9066.10 632.79 279.01 3.96
ioc::network::libos::push 8800.48 16585.63 7484.65 6.05
demikernel::push 8800.48 550.85 243.14 0.14
ioc::network::libos::pop;catnap::linux::transport::pop 8024.05 409.83 176.68 1.45
ioc::network::libos::pop 7815.57 21449377.27 10375230.87 25.30
demikernel::pop 7815.57 586.18 254.43 0.11
ioc::network::libos::pushto 548.67 8259.77 3518.08 23.13
ioc::network::libos::pushto;catnap::linux::transport::push 548.67 515.66 218.41 6.21
demikernel::pushto 548.67 499.27 211.74 1.44
demikernel::async_close 32.50 1477.20 647.57 0.02
ioc::network::libos::connect 24.95 6131676.62 3373900.89 28.93
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 93114.32 43180.93 2.98
demikernel::connect 24.95 2221.79 1012.13 0.01
ioc::network::libos::close 18.35 25094.51 10973.94 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 23717.35 10370.50 94.50
demikernel::accept 15.42 1427.67 602.91 0.00
ioc::network::libos::accept 15.41 903360264.93 377915834.05 44.74
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 7833.57 3351.02 0.00
demikernel::socket 9.50 158286.54 69271.20 0.30
demikernel::socket;catnap::linux::transport::socket 9.50 155973.28 68280.30 96.63
demikernel::new 1.00 269101.15 119583.73 0.15
demikernel::bind 1.00 31132.18 13081.46 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 26139.48 10982.38 83.58
demikernel::listen 1.00 16534.34 6942.94 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 15345.21 6442.76 92.67
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnip
commit id = d29bdf7

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once 28461090.17 349.73 143.37 76.08
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 28461090.17 200.48 82.17 57.38
bgc::inetstack::poll 14230545.08 923.01 378.56 35.83
bgc::inetstack::tcp::established::background 11060.66 1131.46 459.08 0.10
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11060.66 320.52 129.69 25.88
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11049.16 351.19 144.15 31.82
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11007.00 308.46 119.95 14.48
ioc::network::libos::pop 9103.98 352.08 144.33 0.02
demikernel::sgafree 8922.70 100.65 41.36 0.01
ioc::network::libos::push;inetstack::push 8762.80 2032.37 862.20 0.66
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 342.70 145.42 16.06
ioc::network::libos::push 8073.74 33472234.77 14272567.15 26.77
demikernel::push 8073.74 676.22 283.54 0.04
demikernel::sgaalloc 6730.33 128.72 54.08 0.01
demikernel::pop 6109.24 539.83 219.91 0.02
bgc::inetstack::poll;inetstack::poll_bg_work::for::for 4534.97 2036.29 812.58 1.33
ioc::network::libos::pushto 3755.67 1619.45 687.80 0.16
ioc::network::libos::pushto;inetstack::push 3755.67 1020.37 433.87 60.30
demikernel::pushto 3755.67 655.83 278.63 0.06
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 3755.67 293.02 124.38 31.04
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;udp::receive 1475.00 267.76 114.15 67.91
ioc::network::libos::close 49.45 5923.26 2435.63 0.01
ioc::network::libos::connect 41.86 35414.74 14443.08 0.04
bgc::inetstack::tcp::passiveopen::background 41.86 34090.61 14456.43 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6262.57 2594.09 19.47
ioc::network::libos::accept 38.82 1951.96 824.54 0.00
demikernel::async_close 32.50 704.22 270.22 0.00
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;catnip::runtime::transmit 22.43 608.70 254.26 3.40
demikernel::accept 21.86 1478.22 607.61 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 18474.91 7851.14 19.13
demikernel::connect 20.93 2777.52 1147.77 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 20.93 593.93 244.05 11.49
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 20.40 1096.20 451.27 7.97
demikernel::socket 10.30 1450.75 599.01 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 7.80 1003.30 430.63 0.07
bgc::inetstack::arp::background 6.50 2203.03 902.52 0.00
bgc::inetstack::icmp::background 1.05 3067.12 1256.58 0.00
demikernel::new 1.00 1749915227.30 716845916.14 47.01
demikernel::bind 1.00 11545.56 4720.09 0.00
demikernel::listen 1.00 4697.07 1975.79 0.00
demikernel::close 0.00 nan nan 0.00

Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iyzhang iyzhang merged commit 4eac415 into dev Dec 13, 2024
14 checks passed
@iyzhang iyzhang deleted the bugfix-inetstack-mac branch December 13, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inetstack] Configurable dummy MAC address
2 participants