Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update capi to 1.2.10 #199

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Update capi to 1.2.10 #199

wants to merge 5 commits into from

Conversation

dineshba
Copy link

@dineshba dineshba commented Feb 8, 2023

As per this migration steps, below are the changes.

Done:

  1. Updated go version to 1.18.x
  2. Updated controller-runtime v0.11.x => v0.12.3
  3. Added kubernetes marker to describe the merge-strategy for server side apply.
  4. Logging via component-base/logs and deprecation of klog flags

Changes skipped (which are present in above link):

  1. As there no existing immutability checks for InfrastructureMachineTemplate, skipping the validator changes.
  2. No changes for cert-manager version

nks5295
nks5295 reviewed Feb 9, 2023
View reviewed changes
api/v1beta1/types.go
@@ -93,6 +93,8 @@ type VnetSpec struct {
}

// Subnets is a slice of Subnet.
// +listType=map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the generated crd base manifests change after adding these new markers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nks5295 nks5295 nks5295 left review comments

@nwoodmsft nwoodmsft Awaiting requested review from nwoodmsft nwoodmsft will be requested when the pull request is marked ready for review nwoodmsft is a code owner

@zawachte zawachte Awaiting requested review from zawachte zawachte will be requested when the pull request is marked ready for review zawachte is a code owner

@pradipd pradipd Awaiting requested review from pradipd pradipd will be requested when the pull request is marked ready for review pradipd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dineshba @nks5295