Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CLS approach #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating CLS approach #611

wants to merge 1 commit into from

Conversation

AbdelrhmanMagdy
Copy link
Collaborator

No description provided.

@AbdelrhmanMagdy AbdelrhmanMagdy changed the title Updating our CLS approach Updating CLS approach Jun 3, 2024
ender336
ender336 reviewed Jul 29, 2024
View reviewed changes
packages/clarity-js/src/performance/observer.ts
sessionEntries = [entry];
}
// Scale the value to avoid sending back floating point number
metric.max(Metric.CumulativeLayoutShift, entry["value"] * 1000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entry["value"]

should this maybe be sessionValue instead? As it stands, I'm not sure I understand what the purpose of sessionValue would have been (or any of the updated logic)

ender336
ender336 requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ender336 ender336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ender336 ender336 ender336 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdelrhmanMagdy @ender336