Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in bobuilder-ai-orchestrator #4837

Merged

Conversation

JhontSouth
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new errors and warnings incoming in the latest version of ESLint packages in bobuilder-ai-orchestrator.

Specific Changes

  • Removed eslint.config.cjs file.
  • Formatted with required spaces and comment lines required by ESLint.
  • Added some skips in rules that can be applied to the current logic.

Testing

The following image shows the lint command running without problems in botbuilder-ai-orchestrator.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 20, 2024 18:00
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12436162853

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.625%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 1 68.83%
Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 9198d2a into main Jan 6, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-issues-botbuilder-ai-orchestrator branch January 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants