New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESLint issues in botframework-schema #4836

Open

JhontSouth wants to merge 2 commits into main from southworks/fix/eslint-issues-botframework-schema

Collaborator

JhontSouth commented Dec 20, 2024

Addresses #4684
#minor

Description

This PR fixes the new ESLint issues after upgrading the ESLint packages in the botframework-schema library.

Specific Changes

Removed botframework-schema eslint.config.cjs file.
Applied the expected corrections to all the issues detected by ESLint.
Added needed skip lines.

Testing

The following image shows the issues fixed in the library.

JhontSouth added 2 commits

November 14, 2024 11:36


          fix eslint issues in botframework-schema

ef58b03


          Merge branch 'main' into southworks/fix/eslint-issues-botframework-sc…

a705ffd

…hema

JhontSouth requested a review from a team as a code owner

December 20, 2024 17:48

coveralls commented Dec 20, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 12436035996

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.625%

Totals
Change from base Build 12259066809:	0.0%
Covered Lines:	20513
Relevant Lines:	23091

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet