New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESLint issues in botbuilder-dialogs #4832

Open

JhontSouth wants to merge 5 commits into main from southworks/fix/eslint-issues-botbuilder-dialogs

Collaborator

JhontSouth commented Dec 20, 2024

Addresses #4684
#minor

Description

This PR fixes the new errors and warnings incoming in the latest version of ESLint packages in botbuilder-dialogs.

Specific Changes

Removed eslint.config.cjs file.
Fixed ESLint issues by running --fix flag.
Added missing documentation and removed unnecessary spaces.
Added some skips to rules that don't follow the current logic.
Removed duplicated unit test and combined logic of these two.

Testing

The following image shows the lint command running without problems in botbuilder-dialogs.

JhontSouth added 5 commits

November 14, 2024 10:20


          fix eslint issues in botbuilder-dialogs

5e6c0cb


          add eslint config file

21bc218


          combine unit tests and remove duplicated

63ea162


          initialize this.endReason

777b14f


          Merge branch 'main' into southworks/fix/eslint-issues-botbuilder-dialogs

aff010f

JhontSouth requested a review from a team as a code owner

December 20, 2024 17:27

coveralls commented Dec 20, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 12435761505

Details

18 of 18 (100.0%) changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 84.624%

Totals
Change from base Build 12259066809:	-0.001%
Covered Lines:	20512
Relevant Lines:	23090

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet