Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in bobuilder-core #4827

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Dec 20, 2024

Addresses #4684
#minor

Description

This PR fixes all the new errors and warnings incoming in the latest version of ESLint packages

Specific Changes

  • Added missing params documentation in some methods.
  • Formatted with required spaces and comment lines required by ESLint,
  • Lint command pointing to main ESLint config file.

Testing

The following image shows the lint command running without problems in botbuilder-core.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 20, 2024 16:34
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12435024176

Details

  • 22 of 24 (91.67%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.627%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/skills/skillConversationIdFactory.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 12259066809: 0.002%
Covered Lines: 20518
Relevant Lines: 23096

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit cf79813 into main Jan 6, 2025
16 of 17 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-issues-botbuilder-core branch January 6, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants