Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-dialogs-adaptive-testing #4821

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes all the new ESLint errors and warnings that appeared after the ESLint packages' upgrade in the botbuilder-dialogs-adaptive-testing project.

Specific Changes

  • Removed 'only-warn' plugin from 'botbuilder-dialogs-adaptive-testing'.
  • All updated TS and JS files were due to prettier, mocha, and new jsdoc rules.
  • Some values in the ResponseStatusCode enum were skipped with ESLint due to having duplicated values. We added description and group them in the Synonyms section.
  • Some unit tests had their name duplicated, we updated them accordingly.

Testing

The following image shows that there are no more ESLint issues.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner December 20, 2024 13:00
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12431883287

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20514
Relevant Lines: 23092

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants