Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: Update p-map package #4820

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

bump: Update p-map package #4820

wants to merge 8 commits into from

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR updates the p-map version to the latest version and applies the necessary configuration to keep the compatibility in every library.

Specific Changes

  • Updated p-map to version ^7.0.3.
  • Added prebuild scripts to botbuilder-azure and botbuilder-azure-blobs to use tsup to compile ESM-only package.
  • Updated imports of p-map in every class.
  • Removed p-map from botbuilder-repo-utils.

Testing

The following images show the botbuilder-azure and botbuilder-azure-blobs unit tests working after the updates.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 19, 2024 13:33
@coveralls
Copy link

coveralls commented Dec 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12413737458

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%
Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JhontSouth @coveralls