Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4684] Update applicationinsights dependency to version 2.x #4758

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ceciliaavila
Copy link
Collaborator

@ceciliaavila ceciliaavila commented Sep 26, 2024

Addresses #4684
#minor

Description

This PR updates the applicationinsights package to version 2.9.6, the latest compatible version.
Upgrading to version 3.x will introduce breaking changes as it requires to initialize the instrumentation before the bot is executed (issue).

Specific Changes

  • Updated applicationinsights from 1.7.5 to 2.9.6 in botbuilder-applicationinsights.
  • Updated applicationinsights from 1.7.5 to 2.9.6 in root's package.json file.

Testing

The following image shows the unit tests passing and the telemetry logged by a bot with the custom properties in place.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 26, 2024 13:22
@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11053165582

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.349%

Totals Coverage Status
Change from base Build 10930026932: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a14e2f0 into main Sep 26, 2024
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/appinsights-v2 branch September 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants