Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace globby with fast-glob #4745

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR replaces the package globby with fast-glob to avoid errors with the latest version of globby.

Specific Changes

  • Added fast-glob 3.3.2 in botbuilder-repo-utils.
  • Removed globby from botbuilder-repo-utils.

Testing

The following image shows the botbuilder-repo-utils running successfully after the changes.
image

@JhontSouth JhontSouth requested a review from a team as a code owner September 11, 2024 16:46
@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10816001312

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.407%

Totals Coverage Status
Change from base Build 10800481624: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit fd3c722 into main Sep 17, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/replace-globby branch September 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants